Silence warning in Stem::get_beaming ()

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5705 Silence warning in Stem::get_beaming ()

Status: Fixed

Owner: Dan Eble

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2020-02-08

Created: 2020-01-27

Creator: Dan Eble

Private: No

Second attempt: https://codereview.appspot.com/565610043/
First attempt: ~~https://codereview.appspot.com/561350044~~

Discussion

Anonymous - 2020-01-28

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-28

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-31

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-31

Patch on countdown for Feb 2nd

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-02

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-02

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2020-02-02

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2020-02-02

commit bd1866921efe6b0ffbc51c83dc2c2bb64f3fc583 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Fri Dec 6 18:07:47 2019 -0500
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Dan Eble - 2020-02-03
  
  commit f20eed0b629bbc1404e8b37b91d4df296aff1483 (origin/staging) Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Feb 3 15:31:52 2020 -0500 Revert "Issue 5705: int->long in Stem::get_beaming and set_beaming" This reverts commit bd1866921efe6b0ffbc51c83dc2c2bb64f3fc583.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2020-02-03

Issue 5705: Cast to silence warning in Stem::get_beaming ()

https://codereview.appspot.com/565610043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2020-02-03

summary: int->long in Stem::get_beaming and set_beaming --> Silence warning in Stem::get_beaming ()

Description has changed:

Diff:

--- old +++ new @@ -1,4 +1,2 @@ -Fixes a type-conversion warning because scm_ilength () returns a long. -Other changes are for consistency. - -https://codereview.appspot.com/561350044 +Second attempt: https://codereview.appspot.com/565610043/ +First attempt: <strike> https://codereview.appspot.com/561350044 </strike>

Needs: -->

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2020-02-03

implement suggestions

https://codereview.appspot.com/565610043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-04

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-04

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-06

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-06

Patch on countdown for Feb 8th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-08

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-08

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2020-02-08

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2020-02-08

commit d8df79db7776e4f635f4dd01f1cbfb0582aaf0d2 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Feb 3 15:46:24 2020 -0500

Last edit: Dan Eble 2020-02-08
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: