Menu ▾ ▴

#5703 Run scripts/auxiliar/fixcc.py

Fixed
David Kastrup
Fixed_2_21_0 (565) Fixed_2_20_0 (1)
Maintainability
2020-03-22
2020-01-27
David Kastrup
No

Run scripts/auxiliar/fixcc.py

Slated to be applied (or rather rerun) to stable and unstable branches short before release of 2.20.
http://codereview.appspot.com/549480043

Discussion

  • Anonymous

    Anonymous - 2020-01-27
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2020-01-27

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2020-01-29

    Leaving on Review (see description).

     

  • Anonymous

    Anonymous - 2020-01-31

    Am I still leaving this on Review? If not this can be moved to 'Patch on countdown for Feb 2nd'

     

  • Anonymous

    Anonymous - 2020-02-02

    Am I still leaving this on Review? If not this can be moved to 'Patch on countdown for Feb 4th'

     

  • David Kastrup

    David Kastrup - 2020-02-02
    • Patch: review --> countdown
    • Type: Enhancement --> Maintainability
     

  • David Kastrup

    David Kastrup - 2020-02-02

    I am moving this to countdown. While our formatting discussion is still in progress, this is just reapplying a procedure that corresponds to our current formatting practice (which we just slacked off on). So it doesn't really make a difference with regard to the current discussion of changing the formatting procedure. And makes it easier to see the difference it would make...

     

  • Anonymous

    Anonymous - 2020-02-04
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2020-02-04

    Patch counted down - please push (if applicable)

     

  • David Kastrup

    David Kastrup - 2020-02-06

    I am keeping this at Patch-push right now: I will apply reformatting (in both stable and unstable branches) once the 2.20 branch is in a state where further cherry-picking is unlikely. Hopefully in a few day. Not setting this back to Patch-waiting so that people don't get surprised when it does move in and have the ability to object until it does so.

     

  • David Kastrup

    David Kastrup - 2020-02-06
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,5 +1,4 @@
 Run scripts/auxiliar/fixcc.py

-This is just intended to showcase the current fixes fixcc would cause.
-
+Slated to be applied (or rather rerun) to stable and unstable branches short before release of 2.20.
 http://codereview.appspot.com/549480043
     

  • David Kastrup

    David Kastrup - 2020-03-22
    • labels: --> Fixed_2_21_0, Fixed_2_20_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • David Kastrup

    David Kastrup - 2020-03-22

    Pushed (both in an up-to-date version) to staging as

    commit 786c3669ff08804465a89013d349fc745fd783c9
    Author: David Kastrup dak@gnu.org
    Date: Sun Mar 22 16:36:42 2020 +0100

    Issue 5703: Run scripts/auxiliar/fixcc.py

Run

    scripts/auxiliar/fixcc.py --sloppy $(git ls-files '*.cc' '*.hh' '*.icc' '*.tcc')

in order to reformat C++ source files.

    and incidentally to stable/2.20 as

    commit 7d2400474975116f35005f23f36b98688d32a150
    Author: David Kastrup dak@gnu.org
    Date: Sat Feb 29 02:16:13 2020 +0100

    Run scripts/auxiliar/fixcc --sloppy $(git ls-files '*.cc' '*.hh' '*.icc' '*.tcc')