Menu

#5702 Disable C++ exceptions

Fixed
Enhancement
2020-02-02
2020-01-27
No

Disable C++ exceptions

1) Drop exception handling around scm_boot_guile

Doing this at the end of main() is pointless.

2) Disable exception handling code

We don't throw in LilyPond and it's only bloating the executable:
before: 192,586,512B
after: 166,845,952B (-13.3%)

This might also have a positive effect on the build time as well as
performance during runtime, but I didn't try to measure that for now.

http://codereview.appspot.com/571430048

Discussion

  • Anonymous

    Anonymous - 2020-01-27
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-01-27

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-01-29

    Leaving on review as this seems to be still under much discussion.

     
  • Anonymous

    Anonymous - 2020-01-31
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-01-31

    I think this can be moved to 'Patch on countdown for Feb 2nd' but can you check the Rietveld as I don't know if the last comment is enough to hold up the patch (either for change or more discussion).

    (Patch on countdown for Feb 2nd)

     
    • Jonas Hahnfeld

      Jonas Hahnfeld - 2020-01-31

      As far as I understand, the consensus was that we don't need and don't want to use exceptions right now.

       
  • Anonymous

    Anonymous - 2020-02-02
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-02-02

    Patch counted down - please push.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-02
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-02-02

    pushed to staging as

    commit e5f3804875a9ac6294f8ccf899760dc109f8824a
    Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    AuthorDate: Mon Jan 27 14:45:06 2020 +0100
    Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    CommitDate: Sun Feb 2 09:53:11 2020 +0100
    
        Issue 5702/2: Disable exception handling code
    
        We don't throw in LilyPond and it's only bloating the executable:
        before: 192,586,512B
        after:  166,845,952B (-13.3%)
    
        This might also have a positive effect on the build time as well as
        performance during runtime, but I didn't try to measure that for now.
    
    commit 58093859c8c05324ed653a67b496edfdb558ae07
    Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    AuthorDate: Mon Jan 27 14:44:11 2020 +0100
    Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
    CommitDate: Sun Feb 2 09:52:59 2020 +0100
    
        Issue 5702/1: Drop exception handling around scm_boot_guile
    
        Doing this at the end of main() is pointless.
    
     
MongoDB Logo MongoDB