reduce dynamic casting

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5695 reduce dynamic casting

Status: Fixed

Owner: Dan Eble

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2020-01-29

Created: 2020-01-25

Creator: Dan Eble

Private: No

1: defer dynamic_cast in Tie_column::add_tie
2: reduce unsmobbing in Spaceable_grob::get_spring
3: reduce unsmobbing in Paper_column::is_musical

https://codereview.appspot.com/575530107

Discussion

Dan Eble - 2020-01-25

simplify Spaceable_grob::get_spring

https://codereview.appspot.com/575530107

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-26

Description has changed:

Diff:

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-26

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-27

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-27

Patch on countdown for Jan 29th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-29

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-29

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2020-01-29

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

commit 15490d9cd052bd3b59307f4c80543b6671298601
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Fri Jun 8 16:23:21 2018 -0400

    Issue 5695/3: reduce unsmobbing in Paper_column::is_musical

commit c97fe97dd3b4c449accb3f057d61b5f32095e6b3
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Fri Jun 8 16:23:21 2018 -0400

    Issue 5695/2: reduce unsmobbing in Spaceable_grob::get_spring

commit 67b67a89f6c9e31b0726c6482c3e48c9b708ee4b
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Fri Jun 8 16:23:21 2018 -0400

    Issue 5695/1: defer dynamic_cast in Tie_column::add_tie

Gen AI apps are built with MongoDB Atlas

Atlas offers built-in vector search and global availability across 125+ regions. Start building AI apps faster, all in one place.

Try Free →