If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-26
Passes make, make check and a full make doc.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-27
Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-27
Patch on countdown for Jan 29th
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-29
Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-29
Patch counted down - please push. If you don't have commit access David, can you attach a git formatted patch (from current master) and someone can push it for you? Thank you.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-31
David, I cannot seem to apply this patch. Can you rebase it and try again?
e.g
james@Zeus:~/lilypond-git$gitam~/Desktop/0001-Doc-Corrected-doc-string-for-ly-dimension.patchApplying:Doc:Correcteddocstringforly:dimension?error:patchfailed:lily/general-scheme.cc:260error:lily/general-scheme.cc:patchdoesnotapplyPatchfailedat0001Doc:Correcteddocstringforly:dimension?Use'git am --show-current-patch'toseethefailedpatchWhenyouhaveresolvedthisproblem,run"git am --continue".Ifyouprefertoskipthispatch,run"git am --skip"instead.Torestoretheoriginalbranchandstoppatching,run"git am --abort".
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
commit4e438ed4393302b6a0e3dc77a4541496776beb1fAuthor:DavidStephenGrant<david@davidgrant.no>AuthorDate:SatJan2518:37:292020+0100Commit:DavidKastrup<dak@gnu.org>CommitDate:WedJan2916:06:342020+0100Doc:Correcteddocstringforly:dimension?ly:dimension?isapredicate-itdoesnotreturnanumber.diff--gita/lily/general-scheme.ccb/lily/general-scheme.ccindexd2f3fbdf8b..98a49f5ada100644---a/lily/general-scheme.cc+++b/lily/general-scheme.cc@@-260,7+260,7@@LY_DEFINE(ly_unit,"ly:unit",0,0,0,(),}LY_DEFINE(ly_dimension_p,"ly:dimension?",1,0,0,(SCMd),-"Return @var{d} as a number. Used to distinguish length"+"Is @var{d} a dimension? Used to distinguish length"" variables from normal numbers."){returnscm_number_p(d);
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
Passes make, make check and a full make doc.
Patch on countdown for Jan 29th
Patch counted down - please push. If you don't have commit access David, can you attach a git formatted patch (from current master) and someone can push it for you? Thank you.
Patch attached. Thanks!
David, I cannot seem to apply this patch. Can you rebase it and try again?
e.g
The patch is already in
master, that's why it doesn't apply ;-)in
master: