Menu ▾ ▴

#5690 Tiny fixes for extractpdfmark

Fixed
Jonas Hahnfeld
Fixed_2_21_0 (565)
2020-01-31
2020-01-25
Jonas Hahnfeld
No

Tiny fixes for extractpdfmark

Individual changes:
1) Fix extractpdfmark not coming from PATH

If STEPMAKE_PROGS cannot find an optional program, it returns "false".
Checking for this value is better than requiring exactly "extractpdfmark"
which does not hold if the program is not in PATH and the user explicitly
sets the environment variable EXTRACTPDFMARK.

2) Fix extractpdfmark with GhostScript 9.50

GhostScript 9.50 defaults to -dSAFE, so the build system needs to pas
in -dNOSAFE explicitly.

3) Update message for optional extractpdfmark

From my experiments, enabling extractpdfmark rather increases the
required disk space. This is probably because the process produces
additional intermediate files. It only benefits the final PDF docs.

http://codereview.appspot.com/571420055

Discussion

  • Anonymous

    Anonymous - 2020-01-25
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2020-01-25

    Passes make, make test-baseline and a full make doc

     

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-27
     

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-27

    I only changed one string, please consider skipping another "review" phase.

     

    • David Kastrup

      David Kastrup - 2020-01-27

      "Jonas Hahnfeld" hahnjo@users.sourceforge.net writes:

      I only changed one string, please consider skipping another "review" phase.

      James' job is primarily implementing a process, not having to make
      decisions. If you consider skipping a step is warranted and you are
      going to take responsibility for it, spell it out and do so.

      It's worth noting that when Texinfo markup comes into play, inadvertant
      misspellings may render documentation uncompilable. A change only in
      text tends to be harmless in comparison.

      --
      David Kastrup

       

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-27
    • summary: Tiny fixes for "Extract PDFmark" --> Tiny fixes for extractpdfmark
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,4 +1,4 @@
-Tiny fixes for "Extract PDFmark"
+Tiny fixes for extractpdfmark

 Individual changes:
 1) Fix extractpdfmark not coming from PATH
@@ -15,7 +15,7 @@

 3) Update message for optional extractpdfmark

-From my experiments, enabling Extract PDFmark rather increases the
+From my experiments, enabling extractpdfmark rather increases the
 required disk space. This is probably because the process produces
 additional intermediate files. It only benefits the final PDF docs.
    • Needs: -->
    • Type: -->
     

  • Anonymous

    Anonymous - 2020-01-28
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2020-01-28

    Passes make, make test-baseline and a full make doc

     

  • Anonymous

    Anonymous - 2020-01-29
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2020-01-29

    Patch on countdown for Jan 31st.

     

  • Anonymous

    Anonymous - 2020-01-31
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2020-01-31

    Patch counted down - please push.

     

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-31
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-31

    Pushed to staging as

    commit fc1c2f954e2665260bbddd624b9dff9cf126aadf
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Mon Jan 27 14:45:06 2020 +0100
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Fri Jan 31 21:46:41 2020 +0100

    Issue 5690/2: Disable exception handling code

    We don't throw in LilyPond and it's only bloating the executable:
    before: 192,586,512B
    after:  166,845,952B (-13.3%)

    This might also have a positive effect on the build time as well as
    performance during runtime, but I didn't try to measure that for now.

commit e695deeb56486aa45e8e8483fb94b3d05db48fcc
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Mon Jan 27 14:44:11 2020 +0100
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Fri Jan 31 21:46:28 2020 +0100

    Issue 5690/1: Drop exception handling around scm_boot_guile

    Doing this at the end of main() is pointless.
     

    • Jonas Hahnfeld

      Jonas Hahnfeld - 2020-01-31

      Nope, this were the wrong commits :-( re-created staging without these

       

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-31

    The correct commits:

    commit 308eb34190c8c4423eab4911bbe4f91a8fd02b43
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Sat Jan 25 09:44:20 2020 +0100
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Fri Jan 31 21:53:10 2020 +0100

    Issue 5690/3: Update message for optional extractpdfmark

    From my experiments, enabling extractpdfmark rather increases the
    required disk space. This is probably because the process produces
    additional intermediate files. It only benefits the final PDF docs.

commit ae0ad3aede7426a9d6885724bea2eecdb9a22072
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Sat Jan 25 09:43:50 2020 +0100
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Fri Jan 31 21:53:07 2020 +0100

    Issue 5690/2: Fix extractpdfmark with GhostScript 9.50

    GhostScript 9.50 defaults to -dSAFE, so the build system needs to
    pass in -dNOSAFE explicitly.

commit 8d04fe2790b357e7fa4107d168b9173876966be4
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Sat Jan 25 09:43:44 2020 +0100
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Fri Jan 31 21:52:54 2020 +0100

    Issue 5690/1: Fix extractpdfmark not coming from PATH

    If STEPMAKE_PROGS cannot find an optional program, it returns "false".
    Checking for this value is better than requiring exactly "extractpdfmark"
    which does not hold if the program is not in PATH and the user explicitly
    sets the environment variable EXTRACTPDFMARK.
     
MongoDB Logo MongoDB