Menu

#5686 Simplify and speed up uniquify

Fixed
Enhancement
2020-01-30
2020-01-24
No

Previously we sorted the array twice. Instead, we use a hash set. This
makes the procedure O(N) rather than O(N log N).

https://codereview.appspot.com/583390043

Discussion

  • Han-Wen Nienhuys

     
  • Han-Wen Nienhuys

     
  • Anonymous

    Anonymous - 2020-01-24
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2020-01-24

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-01-27
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-01-27

    Patch on countdown for Jan 29th

     
  • Anonymous

    Anonymous - 2020-01-29
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-01-29

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2020-01-30
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2020-01-30
    Issue 5686: Simplify and speed up uniquify
    author  Han-Wen Nienhuys <hanwen@lilypond.org>  
        Wed, 29 Jan 2020 15:28:26 +0000 (16:28 +0100)
    committer   David Kastrup <dak@gnu.org> 
        Wed, 29 Jan 2020 15:28:26 +0000 (16:28 +0100)
    commit  4f04d8b41fd947d48668c389f9c94e4176127544
    
     
MongoDB Logo MongoDB