If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-28
Description has changed:
Diff:
--- old+++ new@@ -3,4 +3,4 @@Don't try to tune the GUILE 1.8 GC if we are on GUILE 2.
-https://codereview.appspot.com/577380043+https://codereview.appspot.com/573420043
Needs: -->
Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-28
Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-28
Passes make, make check and a full make doc.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-31
Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-01-31
Patch on countdown for Feb 2nd
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-02-02
Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-02-02
Patch counted down - please push.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-02-02
labels: --> Fixed_2_21_0
status: Started --> Fixed
Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Just found in gc's source code: The environment variable GC_FREE_SPACE_DIVISOR does the same, without creating a dependency on the library and with a possibility for the user to change the value.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Just found in gc's source code: The environment variable
GC_FREE_SPACE_DIVISOR does the same, without creating a dependency on the
library and with a possibility for the user to change the value.
Status: Fixed Labels: Fixed_2_21_0 Created: Fri Jan 24, 2020 09:48 AM UTC by Han-Wen Nienhuys Last Updated: Sun Feb 02, 2020 07:40 PM UTC Owner: Han-Wen Nienhuys
Setting GC_free_space_divisor to 1 decreases GC time on GUILE v2 from
2.1s to 1.75s, a 17% speedup for the Mozart horn concerto example
Don't try to tune the GUILE 1.8 GC if we are on GUILE 2.
We don't have this (yet), the code just does extern unsigned long GC_free_space_divisor;. But still I think it's a good idea because it allows the user to change it, should there ever be a need.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
cc
https://codereview.appspot.com/577380043
Diff:
Fails make
rebase
https://codereview.appspot.com/577380043
rebase
https://codereview.appspot.com/573420043
This one seems like an unrelated Rietveld issue?
Diff:
Passes make, make check and a full make doc.
Patch on countdown for Feb 2nd
Patch counted down - please push.
Just found in gc's source code: The environment variable
GC_FREE_SPACE_DIVISORdoes the same, without creating a dependency on the library and with a possibility for the user to change the value.Sure, we could use a sane_setenv call with overwrite = false. Send a patch?
On Wed, Feb 5, 2020 at 12:36 PM Jonas Hahnfeld hahnjo@users.sourceforge.net
wrote:
Related
Issues:
#5681"Han-Wen Nienhuys" hanwen@users.sourceforge.net writes:
That sounds quite preferable since it removes the gc.h dependency.
--
David Kastrup
We don't have this (yet), the code just does
extern unsigned long GC_free_space_divisor;. But still I think it's a good idea because it allows the user to change it, should there ever be a need.