Menu

#5677 Set page breaking properties in the System grob

Fixed
2020-02-02
2020-01-22
No

https://codereview.appspot.com/581470047/

Set page breaking properties in the System grob

  • Record system rank within page in rank-on-page property

  • Record page number in page-number property

Discussion

  • Anonymous

    Anonymous - 2020-01-22
    • status: New --> Started
     
  • Anonymous

    Anonymous - 2020-01-22
    • Patch: new --> needs_work
     
  • Anonymous

    Anonymous - 2020-01-22

    Fails 'make'

    ...
    Making Documentation/out/web.texi (copy)
    Making Documentation/out/internals.texi 
    
    Please check the logfile
    
      /home/james/lilypond-git/build/Documentation/out/generate-documentation.log
    
    for errors
    
    /home/james/lilypond-git/build/.././Documentation/GNUmakefile:311: recipe for target 'out/internals.texi' failed
    make[1]: *** [out/internals.texi] Error 1
    /home/james/lilypond-git/build/../stepmake/stepmake/generic-targets.make:6: recipe for target 'all' failed
    make: *** [all] Error 2
    

    Log file shows:

    ...
      [/home/james/lilypond-git/build/out/share/lilypond/current/ly/grace-init.ly]
      [/home/james/lilypond-git/build/out/share/lilypond/current/ly/midi-init.ly
       [/home/james/lilypond-git/build/out/share/lilypond/current/ly/performer-init.ly]]
      [/home/james/lilypond-git/build/out/share/lilypond/current/ly/paper-defaults-init.ly
       [/home/james/lilypond-git/build/out/share/lilypond/current/ly/titling-init.ly]
       [/home/james/lilypond-git/build/out/share/lilypond/current/ly/text-replacements.ly]]
      [/home/james/lilypond-git/build/out/share/lilypond/current/ly/context-mods-init.ly]
      [/home/james/lilypond-git/build/out/share/lilypond/current/ly/engraver-init.ly]]]
    Using `nederlands' note names...
     [/home/james/lilypond-git/ly/generate-documentation.ly
    [/home/james/lilypond-git/build/out/share/lilypond/current/scm/documentation-lib.scm]
    [/home/james/lilypond-git/build/out/share/lilypond/current/scm/lily-sort.scm]
    [/home/james/lilypond-git/build/out/share/lilypond/current/scm/document-functions.scm]
    [/home/james/lilypond-git/build/out/share/lilypond/current/scm/document-translation.scm]
    [/home/james/lilypond-git/build/out/share/lilypond/current/scm/document-music.scm]
    [/home/james/lilypond-git/build/out/share/lilypond/current/scm/document-type-predicates.scm]
    [/home/james/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm]
    [/home/james/lilypond-git/build/out/share/lilypond/current/scm/document-context-mods.scm]
    [/home/james/lilypond-git/build/out/share/lilypond/current/scm/document-backend.scm
    fatal error: define-grob-properties.scm: cannot find interface for property: page-number
    /home/james/lilypond-git/build/out/share/lilypond/current/scm/lily.scm
    
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-26
    • Patch: needs_work --> review
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-26

    @lilypond-pkx reported in https://sourceforge.net/p/testlilyissues/issues/5678/ that the latest patch passes

     
    • David Kastrup

      David Kastrup - 2020-01-26

      Frankly, which version has been tested for which patch seems like a lot of guesswork, so just to make sure, setting to Patch-new.

       
  • David Kastrup

    David Kastrup - 2020-01-26
    • Patch: review --> new
     
  • Anonymous

    Anonymous - 2020-01-27
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-01-27

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-01-29
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-01-29

    Patch on countdown for Jan 31st.

     
  • Anonymous

    Anonymous - 2020-01-31
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-01-31

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2020-02-02
     
  • Anonymous

    Anonymous - 2020-02-02

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2020-02-02
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2020-02-02
    Set page breaking properties in the System grob
    author  Han-Wen Nienhuys <hanwen@lilypond.org>  
        Fri, 17 Jan 2020 22:45:15 +0000 (23:45 +0100)
    committer   Han-Wen Nienhuys <hanwen@lilypond.org>  
        Sun, 2 Feb 2020 13:28:45 +0000 (14:28 +0100)
    commit  b6975f3a7235c86422c683a9896bd3c8ff4a7d2a
    
     
MongoDB Logo MongoDB