LilyIssues / Issues / #5672 Clean up and document include file searching

Anonymous - 2020-01-20

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-20

Passes make,make check an a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-23

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-23

Patch on countdown for January 25th, but these is a question from Dan E on Rietveld.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-25

Leaving on countdown as question from Dan E was not answered.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Han-Wen Nienhuys - 2020-01-25

rebase; const

https://codereview.appspot.com/573400043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-26

Needs: -->

Patch: new --> needs_work

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fails make

...
Making lily/out/score.o < cc
Making lily/out/output-property-engraver.o < cc
Making lily/out/slur-engraver.o < cc
In file included from /home/james/lilypond-git/lily/include/lily-lexer.hh:23:0,
                 from /home/james/lilypond-git/lily/parse-scm.cc:25:
/home/james/lilypond-git/lily/include/includable-lexer.hh:53:15: error: 'string' was not declared in this scope
   std::vector<string> file_name_strings_;
               ^~~~~~
/home/james/lilypond-git/lily/include/includable-lexer.hh:53:15: note: suggested alternatives:
In file included from /usr/include/c++/7/iosfwd:39:0,
                 from /usr/local/include/gmp.h:34,
                 from /usr/local/include/libguile.h:24,
                 from /home/james/lilypond-git/lily/include/lily-guile.hh:32,
                 from /home/james/lilypond-git/lily/include/smobs.hh:23,
                 from /home/james/lilypond-git/lily/include/input.hh:24,
                 from /home/james/lilypond-git/lily/include/parse-scm.hh:23,
                 from /home/james/lilypond-git/lily/parse-scm.cc:20:
/usr/include/c++/7/bits/stringfwd.h:74:33: note:   'std::__cxx11::string'
   typedef basic_string<char>    string;
                                 ^~~~~~
/usr/include/c++/7/bits/stringfwd.h:74:33: note:   'std::__cxx11::string'
In file included from /home/james/lilypond-git/lily/include/lily-lexer.hh:23:0,
                 from /home/james/lilypond-git/lily/parse-scm.cc:25:
/home/james/lilypond-git/lily/include/includable-lexer.hh:53:21: error: template argument 1 is invalid
   std::vector<string> file_name_strings_;
                     ^
/home/james/lilypond-git/lily/include/includable-lexer.hh:53:21: error: template argument 2 is invalid
/home/james/lilypond-git/build/../stepmake/stepmake/c++-rules.make:4: recipe for target 'out/parse-scm.o' failed
make[1]: *** [out/parse-scm.o] Error 1
make[1]: *** Waiting for unfinished jobs....
/home/james/lilypond-git/build/../stepmake/stepmake/generic-targets.make:6: recipe for target 'all' failed
make: *** [all] Error 2

Han-Wen Nienhuys - 2020-01-26

fix compile error

https://codereview.appspot.com/573400043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-26

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-26

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-29

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-29

Patch on countdown for Jan 31st.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-31

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-01-31

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-02

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2020-02-02

In general, it is a good idea to use
git commit --amend
to edit in the issue number of an issue before pushing: that way people have a better chance of locating it in the issue tracker.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2020-02-02

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Clean up and document include file searching
author  Han-Wen Nienhuys <hanwen@lilypond.org>  
    Sat, 25 Jan 2020 12:08:27 +0000 (13:08 +0100)
committer   Han-Wen Nienhuys <hanwen@lilypond.org>  
    Sun, 2 Feb 2020 13:29:29 +0000 (14:29 +0100)
commit  6663fd3fd00083c5b75d988fd0ebfb77e4c01d0e

Clean up and document include file searching

Issue Tracker for LilyPond

Searches

Help

#5672 Clean up and document include file searching

Discussion