Menu ▾ ▴

#5657 Remove vestiges of support for systems without <sstream>

Fixed
Dan Eble
Fixed_2_21_0 (565)
Maintainability
2020-01-14
2020-01-09
Dan Eble
No

A handful of files already included <sstream> unconditionally, so it has
obviously been a requirement for some time.

https://codereview.appspot.com/553350043

Discussion

  • Anonymous

    Anonymous - 2020-01-10
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2020-01-10

    Passes make, make test-baseline and a full make doc.

     

  • Dan Eble

    Dan Eble - 2020-01-10
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,4 +1,4 @@
-A handful of files already included &lt;sstream&gt; unconditionally, so it has
+A handful of files already included `&lt;sstream&gt;` unconditionally, so it has
 obviously been a requirement for some time.

 https://codereview.appspot.com/553350043
    • Type: Enhancement --> Maintainability
     

  • Anonymous

    Anonymous - 2020-01-12
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2020-01-12

    Patch on countdown for Jan 14th

     

  • Anonymous

    Anonymous - 2020-01-14
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2020-01-14

    Patch counted down please push.

     

  • Dan Eble

    Dan Eble - 2020-01-14
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2020-01-14 
    commit 32fb84b1fcc007038490cd5041b0a415bd708dd6 (HEAD -> staging, origin/staging)
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Thu Jan 9 12:32:56 2020 -0500