Menu ▾ ▴

#5654 Cleanup initialization of configure process

Fixed
Jonas Hahnfeld
Fixed_2_21_0 (565)
Enhancement
2020-01-21
2020-01-08
Jonas Hahnfeld
No

Cleanup initialization of configure process

Individual changes:
1. Cleanup directory handling in STEPMAKE_INIT

Get rid of code which configures the Stepmake package, that hasn't been supported for a long time.
Replace $ugh_ugh_autoconf250_builddir by $ac_pwd and @abs_builddi@. I think the latter is actually more correct, but $ac_abs_builddir not available when executing configure.
Replace hacks around $srcdir and @srcdir@ by predefined variables.

  1. Drop unused MICRO_VERSION

  2. Call AC_INIT correctly with all parameters

Version information via m4_esyscmd() by David K.

  1. Remove passing of package variables

http://codereview.appspot.com/549350043

Discussion

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-08

    Take information from VERSION

    http://codereview.appspot.com/549350043

     

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -3,18 +3,16 @@
 Individual changes:
 1. Cleanup directory handling in STEPMAKE_INIT

- * Get rid of code which configures the Stepmake package, that hasn't
-   been supported for a long time.
- * Replace $ugh_ugh_autoconf250_builddir by $ac_pwd and @abs_builddi@.
-   I think the latter is actually more correct, but $ac_abs_builddir
-   not available when executing configure.
- * Replace hacks around $srcdir and @srcdir@ by predefined variables.
+Get rid of code which configures the Stepmake package, that hasn't been supported for a long time.
+Replace $ugh_ugh_autoconf250_builddir by $ac_pwd and @abs_builddi@. I think the latter is actually more correct, but $ac_abs_builddir not available when executing configure.
+Replace hacks around $srcdir and @srcdir@ by predefined variables.

 2. Drop unused MICRO_VERSION

-3. Remove passing of package and invoke AC_INIT correctly
+3. Call AC_INIT correctly with all parameters

-This requires the version information at two locations (VERSION and
-configure.ac), so add a check that these two match.
+Version information via m4_esyscmd() by David K.
+
+4. Remove passing of package variables

 http://codereview.appspot.com/549350043
    • Needs: -->
    • Type: -->
     

  • Anonymous

    Anonymous - 2020-01-09
    • Patch: new --> review
    • Type: --> Enhancement
     

  • Anonymous

    Anonymous - 2020-01-09

    Passes make, make test-baseline and a full make doc.

     

  • Anonymous

    Anonymous - 2020-01-12
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2020-01-12

    Patch on countdown for Jan 14th

     

  • Anonymous

    Anonymous - 2020-01-14
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2020-01-14

    This has been counted down - but I cannot tell for sure if this has been agreed by all of the Devs involved. If it has please push, if not can you update the Tracker/Rietveld?

     

    • Jonas Hahnfeld

      Jonas Hahnfeld - 2020-01-14

      I think the updated version has, at least I'm using the solution provided by @dakas.

       

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-14

    Workaround for read-only source directories

    http://codereview.appspot.com/549350043

     

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-16

    Use m4_esyscmd_s + echo without -n

    http://codereview.appspot.com/549350043

     

  • Anonymous

    Anonymous - 2020-01-17
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     

  • Anonymous

    Anonymous - 2020-01-17

    Passes make, make test-baseline and a full make doc.

     

  • Anonymous

    Anonymous - 2020-01-19
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2020-01-19

    Patch on countdown for Jan 21st.

     

  • Anonymous

    Anonymous - 2020-01-21
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2020-01-21

    Patch counted down - please push.

     

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-21

    pushed to staging as

    commit 0471360de028b3981596bb4688952a49bfb300b1
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Tue Dec 24 15:15:10 2019 +0100
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Tue Jan 21 18:23:03 2020 +0100

    Issue 5654/4: Remove passing of package variables

commit 90e0a31201464bf6bbe0dc5ae93d555f16e6cd75
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Wed Jan 8 21:34:50 2020 +0100
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Tue Jan 21 18:22:26 2020 +0100

    Issue 5654/3: Call AC_INIT correctly with all parameters

    Version information via m4_esyscmd_s() by David K.
    The additional SRCDIR variable is needed for read-only source
    directories. It is used during autoconf and MUST NOT be read
    in the generated configure script itself.

commit 2db727328de836028421ef9d418ed854942f6622
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Tue Dec 24 14:37:07 2019 +0100
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Tue Jan 21 18:21:45 2020 +0100

    Issue 5654/2: Drop unused MICRO_VERSION

commit 194a0001cd0d16a9681c5b53fdab0d4e416a20ce
Author:     Jonas Hahnfeld <hahnjo@hahnjo.de>
AuthorDate: Mon Dec 23 14:50:58 2019 +0100
Commit:     Jonas Hahnfeld <hahnjo@hahnjo.de>
CommitDate: Tue Jan 21 18:21:45 2020 +0100

    Issue 5654/1: Cleanup directory handling in STEPMAKE_INIT

     * Get rid of code which configures the Stepmake package, that hasn't
       been supported for a long time.
     * Replace $ugh_ugh_autoconf250_builddir by $ac_pwd and @abs_builddi@.
       I think the latter is actually more correct, but $ac_abs_builddir
       not available when executing configure.
     * Replace hacks around $srcdir and @srcdir@ by predefined variables.
     

  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-21
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->