Menu

#5653 Cleanup unneeded parts of Stepmake

Fixed
Enhancement
2020-01-14
2020-01-08
No

Cleanup unneeded parts of Stepmake

Individual changes:
1. Remove line break from STEPMAKE_TEMPLATES

It's easier to analyze when all values are in a single line.

  1. Drop unused stepmake templates

A list of needed one can be obtained by the following:
$ git grep "STEPMAKE_TEMPLATES.=" | sed "s/.=\W(.)/\1/" | \
tr ' ' '\n' | sort -u | grep -v "\\$"

However we cannot simply delete all others because some are referenced
elsewhere, so it's a manual process of checking the candidates.

  1. Drop support for compiling C files

All source code is C++ by now, move the used rules to c++-*.make.

  1. Simplify python/GNUmakefile

OUT_SO_MODULES and OUT_PYC_MODULES don't exist anymore.

  1. Delete flower/VERSION

This is very old and I don't think this file is used. Also get rid
of FLOWER_VERSION and FULL_FLOWER_VERSION which aren't used either.

  1. Delete no-builtin-rules.make

The implicit rules are only used if no other rule can be found. We
define all needed rules ourselves, so they should not harm.

http://codereview.appspot.com/577280043

Discussion

  • Anonymous

    Anonymous - 2020-01-09
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2020-01-09

    Passes make, make test-baseline and a full make doc.

     
  • Anonymous

    Anonymous - 2020-01-12
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-01-12

    Patch on countdown for Jan 14th

     
  • Anonymous

    Anonymous - 2020-01-14
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-01-14

    Patch counted down - please push

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-14
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2020-01-14

    Pushed to staging as

    commit f48acb57747f3925c90c41ad6c7bc04c00104015
    Author: Jonas Hahnfeld <hahnjo@hahnjo.de>
    Date:   Sat Dec 21 14:00:27 2019 +0100
    
        Issue 5653/6: Delete no-builtin-rules.make
    
        The implicit rules are only used if no other rule can be found. We
        define all needed rules ourselves, so they should not harm.
    
    commit b2bd874f5520a913058f7963bc467ace143565da
    Author: Jonas Hahnfeld <hahnjo@hahnjo.de>
    Date:   Sat Dec 21 13:17:51 2019 +0100
    
        Issue 5653/5: Delete flower/VERSION
    
        This is very old and I don't think this file is used. Also get rid
        of FLOWER_VERSION and FULL_FLOWER_VERSION which aren't used either.
    
    commit f203a1c508e38c5e22cb2ead5a66efe27780f81a
    Author: Jonas Hahnfeld <hahnjo@hahnjo.de>
    Date:   Sat Dec 21 13:12:49 2019 +0100
    
        Issue 5653/4: Simplify python/GNUmakefile
    
        OUT_SO_MODULES and OUT_PYC_MODULES don't exist anymore.
    
    commit 4681522edc5d41ae03830d5d8870803b10d3ac01
    Author: Jonas Hahnfeld <hahnjo@hahnjo.de>
    Date:   Mon Dec 23 12:24:26 2019 +0100
    
        Issue 5653/3: Drop support for compiling C files
    
        All source code is C++ by now, move the used rules to c++-*.make.
    
    commit 22b862e0124fb63baae48bc30952b4f27938d494
    Author: Jonas Hahnfeld <hahnjo@hahnjo.de>
    Date:   Sat Dec 21 12:54:50 2019 +0100
    
        Issue 5653/2: Drop unused stepmake templates
    
        A list of needed one can be obtained by the following:
         $ git grep "STEPMAKE_TEMPLATES.*=" | sed "s/.*=\W*\(.*\)/\1/" | \
              tr ' ' '\n' | sort -u | grep -v "\\\$"
    
        However we cannot simply delete all others because some are referenced
        elsewhere, so it's a manual process of checking the candidates.
    
    commit e3764d619fa89b1a9df957e0e6085bab84c37a9f
    Author: Jonas Hahnfeld <hahnjo@hahnjo.de>
    Date:   Sat Dec 21 12:27:51 2019 +0100
    
        Issue 5653/1: Remove line break from STEPMAKE_TEMPLATES
    
        It's easier to analyze when all values are in a single line.