#5640 Fix regtests about Footnote

[Thomas Morley]

Fix regtests about Footnote

Several regtest about FootnoteItem/Spanner contained overrides
without specifying the context.
Footnote_engraver lives in Score-context, though. Thus the
Score-context is added to the overrides in:
input/regression/footnote-auto-numbering-vertical-order.ly
input/regression/footnote-auto-numbering.ly
input/regression/footnote-spanner.ly
input/regression/in-note.ly
Regtest-diffs are expected.

http://codereview.appspot.com/549320043

[Anonymous]

Fails make check

--snip--

command failed: /home/james/lilypond-git/build/out/bin/lilypond \
    -I /home/james/lilypond-git/input/regression  -dbackend=eps --formats=ps,png,pdf -djob-count=8 -dinclude-eps-fonts -dgs-load-fonts --header=doctitle --header=doctitleca --header=doctitlecs --header=doctitlede --header=doctitlees --header=doctitlefr --header=doctitlehu --header=doctitleit --header=doctitleja --header=doctitlenl --header=doctitlezh --header=texidoc --header=texidocca --header=texidoccs --header=texidocde --header=texidoces --header=texidocfr --header=texidochu --header=texidocit --header=texidocja --header=texidocnl --header=texidoczh -dcheck-internal-types -ddump-signatures -danti-alias-factor=2 -dfont-export-dir=/home/james/lilypond-git/build/out-fonts -O TeX-GS -I  "./"  -I  "/home/james/lilypond-git/build/input/regression"  -I  "/home/james/lilypond-git/input/regression" --formats=eps  -deps-box-padding=3.000000  -dread-file-list -dno-strip-output-dir  "/home/james/lilypond-git/build/out/lybook-db/snippet-names--8837649916314423588.ly"
Child returned 1
Error ignored by lilylib
Error trapped by lilypond-book

Log file for reg test shows

Processing `./df/lily-2c93a0c2.ly'
Parsing...
Renaming input to: `/home/james/lilypond-git/input/regression/footnote-auto-numbering-vertical-order.ly'
Interpreting music...
Preprocessing graphical objects...
Finding the ideal number of pages...
Fitting music on 1 or 2 pages...
Drawing systems...
fatal error: Expecting number 1, got 0
fatal error: Children (0) exited with errors.

[Anonymous]

Let me check that again - I just spotted I didn't have a clean tree.

[Anonymous]

It fails as above.

[Thomas Morley]

Hi James,

actually the error demonstrates /input/regression/footnote-auto-numbering-vertical-order.ly works again.

It was implemented with

commit 5ac2664c2207e8dfa1734d786e5c7b214b275521
Author: Mike Solomon mike@apollinemike.com
Date: Fri Dec 2 08:06:13 2011 +0100

Adds a numbering-assertion-function property to the footnote grob.

This allows the footnote regtests to verify that the footnotes are
being numbered in the correct order.

for 2.15.21

Obviously it worked back in 2.15.21
Though, with:

commit 3f0f59297670174562e7d66ae7dd8d73a04be6f8
Author: David Kastrup dak@gnu.org
Date: Fri May 25 18:41:46 2012 +0200

Issue 1773: move Footnote_engraver to Score context

for 2.15.40

David overlooked to the missing Score-contexts in the regtests.

Now footnote-auto-numbering-vertical-order.ly works again and errors, this may point to a problem.

Continuing research...

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdpwn for Dec 19th

[Anonymous]

Patch counted down - please push

[Anonymous]

Patch counted down - please push

[Thomas Morley]

Pushed to staging as:
commit 2858611c6b6fafbbcaf10b42bb4338aa95b8ed88
Author: Thomas Morley thomasmorley65@gmail.com
Date: Sat Dec 14 12:36:03 2019 +0100

Issue 5640 Fix regtests about Footnote

Several regtest about FootnoteItem/Spanner contained overrides
without specifying the context.
Footnote_engraver lives in Score-context, since Issue 1773.
Probably an oversight.
Thus the Score-context is added to the overrides in:
input/regression/footnote-auto-numbering.ly
input/regression/footnote-spanner.ly
input/regression/in-note.ly
Regtest-diffs are expected.

input/regression/footnote-auto-numbering-vertical-order.ly
is broken as well. This will need some more thoughts, beyond the
scope of this patch.