Menu

#5637 Port lilysong to subprocess module

Fixed
Enhancement
2019-12-17
2019-12-13
No

Port lilysong to subprocess module

popen2 has been removed for Python 3.0.

http://codereview.appspot.com/561240043

Discussion

  • Anonymous

    Anonymous - 2019-12-13
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-12-13

    Passes make, make check and a full make doc

     
  • David Kastrup

    David Kastrup - 2019-12-13

    Is lilysong actually documented somewhere other than its rather cryptic manual page? It seems like something that nobody uses or knows of and that may have stopped working decades ago. There does not seem to be any regtest associated with it. There is an elisp/lilypond-song.el but it's probably unrelated.

     
    • Jonas Hahnfeld

      Jonas Hahnfeld - 2019-12-14

      I haven't come across any and I'm absolutely fine with dropping it. Right now it's executed with --help during the build to generate the man page, so I wanted to fix it for Python 3.

       
    • Jonas Hahnfeld

      Jonas Hahnfeld - 2019-12-14

      In case we want to do this, I've submitted #5641 to remove both lilysong and lilymidi. Neither of them is mentioned in the documentation and I don't see any tests to make sure they actually work. I found elisp/lilypond-song.el to be related in that it call lilysong, so I'm proposing to remove this file as well - guess what, it's not mentioned in the documentation either.

       
  • Anonymous

    Anonymous - 2019-12-15
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-12-15

    Patch on countdown for December 17th,

     
  • Anonymous

    Anonymous - 2019-12-17
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-12-17

    Patch counted down, please push.

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2019-12-17
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2019-12-17

    Pushed as

    commit b320aa66a81a13d76d2804fcc68de93d91a43f8f
    Author: Jonas Hahnfeld <hahnjo@hahnjo.de>
    Date:   Mon Dec 9 20:45:45 2019 +0100
    
        Issue 5637: Port lilysong to subprocess module
    
        popen2 has been removed for Python 3.0.