Menu ▾ ▴

#5636 fix various warnings

Fixed
Dan Eble
Fixed_2_21_0 (565)
Enhancement
2019-12-17
2019-12-13
Dan Eble
No

1: int->vsize in Cluster

2: int->vsize in Grob::pure_is_visible ()
Also, for maintainability, let Item::pure_is_visible () default to
Grob::pure_is_visible () rather than use a hard-coded value.

3: more int->vsize in System
Doesn't fix any warnings now, but will avoid new ones later.

4: int->long for result of scm_ilength ()

https://codereview.appspot.com/583200043

Discussion

  • Dan Eble

    Dan Eble - 2019-12-13
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,12 @@
 1: int->vsize in Cluster

+2: int->vsize in Grob::pure_is_visible ()
+Also, for maintainability, let Item::pure_is_visible () default to
+Grob::pure_is_visible () rather than use a hard-coded value.
+
+3: more int->vsize in System
+Doesn't fix any warnings now, but will avoid new ones later.
+
+4: int->long for result of scm_ilength ()
+
 https://codereview.appspot.com/583200043
    • Needs: -->
    • Type: --> Enhancement
     

  • Anonymous

    Anonymous - 2019-12-13
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2019-12-13

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2019-12-15
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2019-12-15

    Patch on countdown for December 17th,

     

  • Anonymous

    Anonymous - 2019-12-17
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2019-12-17

    Patch counted down, please push.

     

  • Dan Eble

    Dan Eble - 2019-12-17
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2019-12-17 
    commit 10026adbe419f47d838d67b48101ec87450ab9ea
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Fri Dec 6 18:11:40 2019 -0500

    Issue 5636/4: int->long for result of scm_ilength ()

    to fix type-conversion warnings

commit 66248e1750023f638d3d101ae2314fc493fd665e
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Thu Nov 28 18:39:02 2019 -0500

    Issue 5636/3: more int->vsize in System

    Doesn't fix any warnings now, but will avoid new ones later.

commit 21d637346260dae049489fca56859075d3ff307d
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Fri Nov 22 12:05:30 2019 -0500

    Issue 5636/2: int->vsize in Grob::pure_is_visible ()

    Also, for maintainability, let Item::pure_is_visible () default to
    Grob::pure_is_visible () rather than use a hard-coded value.

commit ea2f995be645e3e98742186131829d1f7bc6b89a
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Sat Nov 30 17:29:20 2019 -0500

    Issue 5636/1: int->vsize in Cluster