Menu

#5633 musicxml: Replace new module by type() builtin

Fixed
Enhancement
2019-12-15
2019-12-09
No

musicxml: Replace new module by type() builtin

The new module has been deprecated in Python 2.6 and removed in
version 3.0. The type() builtin is available since Python 2.2 but
it requires new-style bases, so make Xml_node inherit from object.

http://codereview.appspot.com/555070043

Discussion

  • Anonymous

    Anonymous - 2019-12-10
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-12-10

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-12-13
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-12-13

    Patch on couuntdown for Dec 15th.

     
  • Anonymous

    Anonymous - 2019-12-15
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-12-15

    Patch counted down - please push

     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2019-12-15
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Jonas Hahnfeld

    Jonas Hahnfeld - 2019-12-15

    Pushed to staging as

    commit a1494ab840c38ee71decf62d3e924d54d29c91fc
    Author: Jonas Hahnfeld <hahnjo@hahnjo.de>
    Date:   Mon Dec 9 20:12:50 2019 +0100
    
        Issue 5633: musicxml: Replace new module by type() builtin
    
        The new module has been deprecated in Python 2.6 and removed in
        version 3.0. The type() builtin is available since Python 2.2 but
        it requires new-style bases, so make Xml_node inherit from object.