#5624 ignore \barNumberCheck when processing MIDI

[Dan Eble]

Make bar number checks contingent on the new context property
ignoreBarNumberChecks not being true. Set it by default in the MIDI
Score context.

Reword the warning message to avoid confusion with bar checks.

Eliminate input/regression/bar-number-check.ly because it seemed to
duplicate coverage.

https://codereview.appspot.com/579140043

[David Kastrup]

Is a separate property from ignoreBarChecks needed? I am not decided about it.

[Dan Eble]

Here are some reasons for my choosing to add a property for bar number checks and to leave bar checks enabled.

• the bug report was about bar number checks rather than bar checks
• in my own work, I haven't found bar checks in MIDI to be any kind of nuisance
• I can imagine errors I might make involving repeats and alternatives which could be caught by leaving bar checks enabled when rendering unfolded music to MIDI

This position is not strongly held; if someone wanted to take a stand for KISS, I'd be willing to change the patch.

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for Dec 2nd.

[Anonymous]

Patch counted down - please push.

[Dan Eble]

commit ab4f3cd2ad792b848c1045fd572b5f119a180d23 (HEAD -> staging, origin/staging)
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Wed Nov 27 15:05:47 2019 -0500

    Issue 5624: ignore \barNumberCheck when processing MIDI

    Make bar number checks contingent on the new context property
    ignoreBarNumberChecks not being true.  Set it by default in the MIDI
    Score context.

    Reword the warning message to avoid confusion with bar checks.

    Eliminate input/regression/bar-number-check.ly because it seemed to
    duplicate coverage.