Menu ▾ ▴

#5623 fix int/vsize conversion warnings in System

Fixed
Dan Eble
Fixed_2_21_0 (565)
Enhancement
2019-12-02
2019-11-27
Dan Eble
No

1: return vsize from System::element_count and spanner_count
2: use std::count_if for System::spanner_count
3: fix int/vsize conversion warnings in System

https://codereview.appspot.com/553230043

Discussion

  • Dan Eble

    Dan Eble - 2019-11-27
    • Description has changed:

    Diff:
    • Needs: -->
    • Type: --> Enhancement
     

  • Anonymous

    Anonymous - 2019-11-28
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2019-11-28

    Passes make. make check and a full make doc.

     

  • Anonymous

    Anonymous - 2019-11-30
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2019-11-30

    Patch on countdown for Dec 2nd.

     

  • Anonymous

    Anonymous - 2019-12-02
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2019-12-02

    Patch counted down - please push.

     

  • Dan Eble

    Dan Eble - 2019-12-02
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2019-12-02 
    commit 8e418792e6b98d0f7a42eb6303de788c24385565
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Wed Nov 27 10:27:55 2019 -0500

    Issue 5623/3: fix int/vsize conversion warnings in System

commit c0261e9b88c424a185b873e0eda4af54e5f2fa48
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Wed Nov 27 10:18:34 2019 -0500

    Issue 5623/2: use std::count_if for System::spanner_count

commit 8d10192d6c8450dea73cf7534a844040f890a909
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Wed Nov 27 09:58:30 2019 -0500

    Issue 5623/1: return vsize from System::element_count and spanner_count