LilyIssues / Issues / #5622 simplify Spanner pure property cache

Description has changed:

Diff:

--- old
+++ new
@@ -1,10 +1,10 @@
-1. int-&gt;vsize in Spanner
+(1) int-&gt;vsize in Spanner

 This change will avoid new type-conversion warnings when similar
 changes are made in other places in the future.  It does not on its
 own reduce the number of warnings.

-2. simplify Spanner pure property cache
+(2) simplify Spanner pure property cache

 * move construction of key into a function
 * call scm_cons2 instead of calling scm_cons twice

Needs: -->

Dan Eble - 2019-11-27

Needs: -->

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-28

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-28

Passes make. make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-30

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-30

Patch on countdown for Dec 2nd.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-02

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-02

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2019-12-02

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

commit 5d80826390e9d3bd6eb7fb404dfc80d2a86cf04d
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Tue Nov 26 14:49:40 2019 -0500

    Issue 5622/2: simplify Spanner pure property cache

    * move construction of key into a function
    * call scm_cons2 instead of calling scm_cons twice
    * simplify testing whether the cache has been initialized

commit 7877efd58f23ade728f2b7bf1011b8c7c1b1cf40
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Tue Nov 26 14:43:20 2019 -0500

    Issue 5622/1: int->vsize in Spanner

simplify Spanner pure property cache

Issue Tracker for LilyPond

Searches

Help

#5622 simplify Spanner pure property cache

Discussion