LilyIssues / Issues / #5621 Improve positioning of rehearsal marks at the beginning of staff

Description has changed:

Diff:

--- old
+++ new
@@ -1,4 +1,4 @@
-I suggest to change the `break-align-anchor-alignment` property from the `Clef` grob from `RIGHT` to value 2, as shown in the images.
+I suggest to change the default value of the `break-align-anchor-alignment` property from the `Clef` grob from `RIGHT` to value 2, as shown in the images.
 ~~~~
 {
   f&#39;1 | f&#39;1 | \break

Malte Meyn - 2019-11-26

How does this look with clefs other than treble? And with other values for break-align-symbols?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Werner LEMBERG - 2019-11-26

Well, it's not that bad.

{ \clef "treble" f'1 | f'1 | \break \mark #1 f'1 | f'1 | \break \once\override Staff.Clef.break-align-anchor-alignment = #2 \mark #1 f'1 | f'1 | \break \clef "bass" \mark #1 f'1 | f'1 | \break \once\override Staff.Clef.break-align-anchor-alignment = #2 \mark #1 f'1 | f'1 | \break }

Ideally, rehearsal marks should be able to automatically move a little bit to the left or right to minimize the distance to the staff lines. However, this is not possible yet – this would be a great addition!

Given that rehearsal marks are normally positioned at the top of systems, with the highest voices at the top, chances are quite high that the staff with rehearsal marks has a violin clef. I thus vote to make the default value take care of this most common situation.

rehearsal-mark-alignment.png
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Werner LEMBERG - 2019-11-26

By the way: Other elements of break-align-symbols are not affected by my suggested change. Is there anything else besides rehearsal marks that gets attached to clefs in a similar way?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Werner LEMBERG - 2019-11-26

See issue https://sourceforge.net/p/testlilyissues/issues/1150/ for more.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Werner LEMBERG - 2019-12-05

How to proceed?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Werner LEMBERG - 2019-12-10

Description has changed:

Diff:

--- old +++ new @@ -5,3 +5,5 @@ \mark \default f'1 | f'1 | } ~~~~ + +https://codereview.appspot.com/553290043
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-12-10

Patch: --> new
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-10

Passes make, make check and a full make doc.

Reg test diffs are below (this link had expired).

Last edit: Anonymous 2019-12-15

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-13

Leaving on review for now as there seems to be some discussion going on,

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2019-12-15

Issue 5621: Improve rehearsal mark position at beginning of staff

This is a work in progress.

RehearsalMark uses a callback for self-alignment-X that yields the
opposite of the direction specified by the anchor grob.

I don't know if there should be some unpure-pure stuff involved. It
looks like unpure-pure containers are used for vertical placement, and
this is horizontal.

The results are good as far as I have seen in the existing regtests.

input/regression/pedal-bracket.ly probably needs to be updated because
it seems that the position of the mark is important for the test.
Other cases might need similar changes. I need to review them.

I also need to consider regtest coverage and perhaps add more cases.

https://codereview.appspot.com/547340043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous - 2019-12-15
  
  This patch passes make, make check and a full make doc.
  
  Dan's patch's reg test diffs are here: https://cloud-u8zj2dc4b.yourownnet.eu/s/JxCkPH4NKsGDkbg
  
  Werner's patch's reg test diffs are here: https://cloud-u8zj2dc4b.yourownnet.eu/s/x82NgEnwzKKJykj
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Werner LEMBERG - 2019-12-16

Good job, Dan! Your patch is superior to my simple attempt. Xavier?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2019-12-16

remove/revise some regtests

https://codereview.appspot.com/547340043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -5,5 +5,8 @@
   \mark \default f&#39;1 | f&#39;1 |
 }
 ~~~~
+Dan&#39;s suggested Patch - 
+https://codereview.appspot.com/547340043

-https://codereview.appspot.com/553290043
+Werner&#39;s Original Patch - applies to attached png files at start of ticket.
+https://codereview.appspot.com/553290043

Needs: -->
Type: --> Enhancement

Anonymous - 2019-12-17

This patch passes make, make check and a full make doc.

Dan's 17th dec patch's reg test diffs are here: https://cloud-u8zj2dc4b.yourownnet.eu/s/QXJB753MRD8xNnk

older:

Dan's 15th dec patch's reg test diffs are here: https://cloud-u8zj2dc4b.yourownnet.eu/s/JxCkPH4NKsGDkbg

Werner's patch's reg test diffs are here: https://cloud-u8zj2dc4b.yourownnet.eu/s/x82NgEnwzKKJykj

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2019-12-17

Patch: review --> new
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dan Eble - 2019-12-17

This is ready for a full review now.
https://codereview.appspot.com/547340043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-17

assigned_to: Werner LEMBERG --> Dan Eble

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-17

This patch passes make, make check and a full make doc.

diffs as follows

Dan's suggested Patch -
https://codereview.appspot.com/547340043

Dan's Patch #1: https://cloud-u8zj2dc4b.yourownnet.eu/s/R7c3pG3MT25cbsi
Dan's Patch #3: https://cloud-u8zj2dc4b.yourownnet.eu/s/QXJB753MRD8xNnk
Dan's Patch #4: https://cloud-u8zj2dc4b.yourownnet.eu/s/2P7QxpeWRiJdzmM

Werner's Original Patch - applies to attached png files at start of ticket.
https://codereview.appspot.com/553290043
Werner's original patch Set: https://cloud-u8zj2dc4b.yourownnet.eu/s/NmpH5kyom7Jj5mZ

Last edit: Anonymous 2019-12-19

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-19

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-19

Patch on countdown for Dec 21st

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-21

It looks like this isn't quite ready to push (at least from Discussions on Rietveld). I'll leave this on countdpwn (for Dec 23rd) and check again on the next path review.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Dan Eble - 2019-12-21
  
  Yes, please give plenty of time for feedback on this one. I suppose that people are going to be pretty busy in the next week.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-12-25

Leaving on Cuontdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Improve positioning of rehearsal marks at the beginning of staff

Issue Tracker for LilyPond

Searches

Help

#5621 Improve positioning of rehearsal marks at the beginning of staff

Discussion