LilyIssues / Issues / #5610 add suggestAccidentals = #'cautionary option

#5610 add suggestAccidentals = #'cautionary option

Status: Fixed

Owner: Malte Meyn

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2019-11-28

Created: 2019-11-21

Creator: Malte Meyn

Private: No

add suggestAccidentals = #'cautionary option

Setting suggestAccidentals to 'cautionary now prints only cautionary
accidentals (input by ?) as AccidentalSuggestion.

http://codereview.appspot.com/577130043

Discussion

Anonymous - 2019-11-23

Passes make, make check and a full make doc.

Reg test diff attached

Screenshot from 2019-11-23 03-59-54.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-23

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-11-23

add changes entry (untested, see mail on lilypond-devel)

http://codereview.appspot.com/577130043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-24

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-24

Passes make, make check and a full make doc (reg test diff as the first comment)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-25

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-25

Patch on countdown for Nov 27th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-28

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-11-28

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-11-28

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-11-28

commit 28e08cc4c2774752d3aa362464b6b0e56c61e834
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sat Nov 23 12:24:12 2019 +0100

Issue 5610/2: add Changes entry

commit e6cdaabb97264bc5df89309020b89263a0e5e458
Author: Malte Meyn lilypond@maltemeyn.de
Date: Thu Nov 21 12:49:28 2019 +0100

Issue 5610/1: add suggestAccidentals = #'cautionary option Setting suggestAccidentals to 'cautionary now prints only cautionary accidentals (input by ?) as AccidentalSuggestion.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: