Menu ▾ ▴

#5609 prefer the instance method Paper_column::get_rank

Fixed
Dan Eble
Fixed_2_21_0 (565)
Enhancement
2019-11-25
2019-11-20
Dan Eble
No

Prefer the instance method Paper_column::get_rank over the static
method.

The static method can eventually be eliminated, but not until some
other cleaning is done. I have all the changes ready, but I plan to
pace them to avoid review fatigue.

https://codereview.appspot.com/575320043

Discussion

  • Anonymous

    Anonymous - 2019-11-21
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2019-11-21

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2019-11-23
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2019-11-23

    Patch on countdown for Nov 25th

     

  • Anonymous

    Anonymous - 2019-11-25
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2019-11-25

    Patch counted down - please push.

     

  • Dan Eble

    Dan Eble - 2019-11-25
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2019-11-25 
    commit d76c1bfb5dd997e7e8a177e9eca5e8c707e58b16 (HEAD -> staging, origin/staging)
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Wed Nov 20 11:21:23 2019 -0500

    Issue 5609: prefer the instance method Paper_column::get_rank

    ... over the static method.