Menu

#5606 Allow use of `libguile18.h` instead of `libguile.h`.

Fixed
Enhancement
2019-11-23
2019-11-17
No

Allow use of libguile18.h instead of libguile.h.

This is for compilation on MacPorts, and I guess that more distributions
will follow so that guile 1.8 and 2.x can be installed in parallel.

http://codereview.appspot.com/553170043

Discussion

  • Anonymous

    Anonymous - 2019-11-17
    • Description has changed:

    Diff:

    
    
    • assigned_to: Werner LEMBERG
    • Needs: -->
     
  • Anonymous

    Anonymous - 2019-11-17
    • Patch: new --> needs_work
     
  • Anonymous

    Anonymous - 2019-11-17

    This fails make.

    Do I have to do anythin special to test this?

     
  • Werner LEMBERG

    Werner LEMBERG - 2019-11-17

    Thanks for testing; it should work out of the box. What exactly fails?

     
    • Jonas Hahnfeld

      Jonas Hahnfeld - 2019-11-17

      Please see the code review, I think the usage of the new define is wrong. Haven't tested locally if that solves the problem, though

       
  • Werner LEMBERG

    Werner LEMBERG - 2019-11-17

    Wait, I see the error; will soon update the code.

     
  • Anonymous

    Anonymous - 2019-11-18
    • Patch: needs_work --> review
     
  • Anonymous

    Anonymous - 2019-11-18

    Passes make, make test-baseline and a full make doc

     
  • Anonymous

    Anonymous - 2019-11-20
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-11-20

    Patch on countdown for Nov 22nd

     
  • Anonymous

    Anonymous - 2019-11-23
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-11-23

    Patch counted down - please push

     
  • Werner LEMBERG

    Werner LEMBERG - 2019-11-23

    Pushed to staging as

    commit 658a69f548afda9bc0107381aa4bd9142a62a9ac
    Author: Werner Lemberg wl@gnu.org
    Date: Sun Nov 17 16:58:35 2019 +0100

    Issue 5606: allow use of `libguile18.h` instead of `libguile.h`
    
    This is for compilation on MacPorts, and I guess that more distributions
    will follow so that guile 1.8 and 2.x can be installed in parallel.
    
     
  • Werner LEMBERG

    Werner LEMBERG - 2019-11-23
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->