Menu

#5604 fix miscellaneous warnings

Fixed
Dan Eble
Enhancement
2019-11-20
2019-11-16
Dan Eble
No

Commits
1. fix warnings about implicit Input::operator=
2. fix a format-security warning
3. fix a maybe-uninitialized warning

What these have in common is that they are not type-conversion warnings. :)

https://codereview.appspot.com/577100046

Discussion

  • Anonymous

    Anonymous - 2019-11-16
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-11-16

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-11-18
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-11-18

    Patch on countdown for Nov 20th

     
  • Anonymous

    Anonymous - 2019-11-20
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-11-20

    Patch counted down - please push.

     
  • Dan Eble

    Dan Eble - 2019-11-20
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Maintainability
     
  • Dan Eble

    Dan Eble - 2019-11-20
    commit 40998a6ebf59ce9fd7a8f427b7cd89370b25d3a3
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Fri Nov 15 20:05:26 2019 -0500
    
        Issue 5604/3: fix a maybe-uninitialized warning
    
    commit 0582c84aca9fd188affbb6923d7ab313260b1ca6
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Fri Nov 15 19:41:56 2019 -0500
    
        Issue 5604/2: fix a format-security warning
    
    commit f2480f12fecc6ad56141bf49652af3766ead65de
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Fri Nov 15 19:30:43 2019 -0500
    
        Issue 5604/1: fix warnings about implicit Input::operator=
    
     
  • Dan Eble

    Dan Eble - 2019-11-20
    • Type: Maintainability --> Enhancement
     
  • Dan Eble

    Dan Eble - 2019-11-20

    (I was too hasty in changing the type. Fixing a format-security warning is more than maintainability.)

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.