Menu

#5560 remove script-chart.ly

Fixed
Enhancement
2019-10-03
2019-09-28
Malte Meyn
No

At last, this file was used only in the German documentation.
Replacement was copied from the English version.

http://codereview.appspot.com/551010043

Discussion

  • Anonymous

    Anonymous - 2019-09-28
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> needs_work
     
  • Anonymous

    Anonymous - 2019-09-28

    Fails make doc.

    notation-appendices.itely

    You removed the section ' Wiederholungszeichensrkipte' but didn't remove the menu entry at the start of the node.

    ** Node following `Instrumentenspezifische Skripte' in menu `Wiederholungszeichensrkipte' and in sectionning `Wiederholungszeichenskripte' differ 
    ** `Wiederholungszeichenskripte' doesn't appear in menus
    ** `Liste der Artikulationszeichen' is up for `Wiederholungszeichenskripte', but has no menu entry for this node
    ** No node following `Wiederholungszeichenskripte' in menu, but `Skripte der alten Notation' follows in sectionning 
    ...
    etc.
    ...
    *** Unknown node in menu entry `Wiederholungszeichensrkipte' (in out-www/markup-commands.texi l. 7069)
    Max error number exceeded
    
     
    • Malte Meyn

      Malte Meyn - 2019-09-28

      Sorry … It seems like me and make doc will never become friends. (Fun fact: I made this patch because make doc failed when I forgot to change script-chart.ly every time a script was added.) I tried to make doc before uploading but it failed due to some misconfiguration. It was definitely not that typo-related error so I thought it’ll be okay without testing …

      I’ll try to repair my config and make doc first before uploading a corrected patch set.

       
  • Anonymous

    Anonymous - 2019-09-29
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-09-29

    Passes make, make check and a full make doc.

    No apology needed, it's why we have the review process :)

     
  • Anonymous

    Anonymous - 2019-10-01
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-10-01

    Patch on countdown for Oct 3rd

     
  • Anonymous

    Anonymous - 2019-10-03
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-10-03

    Patch counted down - please push

     
  • Malte Meyn

    Malte Meyn - 2019-10-03
    • labels: --> Fixed_2_21_0
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,5 +1,3 @@
    -remove script-chart.ly
    -
     At last, this file was used only in the German documentation.
     Replacement was copied from the English version.
    
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2019-10-03

    commit 09bc2e2ed7a0870a21fd05b84c1fd1050419ed03
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Fri Sep 27 12:39:07 2019 +0200

    Issue 5560: remove script-chart.ly
    
    This file was used only in the German documentation.
    Replacement was copied from the English version.