Menu

#5559 Add user-definable ottavation markups

Fixed
Enhancement
2019-10-08
2019-09-27
Malte Meyn
No

Add user-definable ottavation markups

The context property ottavationMarkups is an alist containing markups
for different octaves. Entries 22ma, 29ma, 22mb, and 29mb were added.

There is a warning when \ottava uses a number of octaves that has no
corresponding markup (alist entry).

Contains regtest

http://codereview.appspot.com/568970043

Discussion

  • Anonymous

    Anonymous - 2019-09-27
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-09-27

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-10-01
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-10-01

    Patch on countdown for Oct 3rd

    Note comments on Rietveld

     
  • Anonymous

    Anonymous - 2019-10-03
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-10-03

    Passes make, make check and a full make doc - reg test diffs can be downloaded from here:

    https://nc-cluster02.yourownnet.cloud/index.php/s/WZ6LfNgoDWEDjzy (~350kb)

     
  • Werner LEMBERG

    Werner LEMBERG - 2019-10-03

    Uh, oh, I see changes in the positions of rest dots...

     
    • Anonymous

      Anonymous - 2019-10-06

      These I are always present in some shape or form. I cannot find the other discussions but this is the first one

      https://lists.gnu.org/archive/html/lilypond-devel/2017-09/msg00022.html

      I am assuming you are referring to

      input/regression/rest-dot-position.ly

      This always shows up in the reg test diff now 50% of the time (at least since 2017).

       

      Last edit: Anonymous 2019-10-06
  • Anonymous

    Anonymous - 2019-10-06
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-10-06

    Patch on countdown for Oct 8th

     
  • Anonymous

    Anonymous - 2019-10-08
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-10-08

    Patch counted down - please push.

     
  • Malte Meyn

    Malte Meyn - 2019-10-08
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2019-10-08

    commit 2f1649830bce08ce351ee34aa1d1de8266d9af39
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Tue Oct 1 17:54:09 2019 +0200

    Issue 5559/4: fix regression (ambitus with ottava)
    

    commit 6f319a862dc9333ed720e989c881b16cf20710e9
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Wed Oct 2 10:23:18 2019 +0200

    Issue 5556/3: make OttavaBracket text default bold
    

    commit 608aa5598868a3772b6ba66f2b3804c9477ffcb3
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Fri Sep 27 10:26:47 2019 +0200

    Issue 5559/2: add regtest
    

    commit 476194c706e4f9898fdbd5847dc1a924843f03e8
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Thu Jul 11 10:52:02 2019 +0200

    Issue 5559/1: Add user-definable ottava markups
    
    The context property ottavationMarkups is an alist containing markups
    for different octaves. There is a warning when \ottava uses a number of
    octaves that has no corresponding markup (alist entry).
    
    The default was changed to numbers without letters (ottavation-numbers),
    two variants ottavation-ordinals and ottavation-simple-ordinals were
    added. All of these contain also entries for 3 and 4 octaves up/down.