Menu

#5550 ly: hel-arabic - comment out Sahnaz entry

Fixed
Enhancement
2019-08-31
2019-08-25
No

ly: hel-arabic - comment out Sahnaz entry

In oriental, Arabic music sometimes different makam names correspond
to a makam mode. We must keep only the real makams

After a thorough search, I noticed that the makam Sahnaz that is in D
is in fact a transposition of the makam alhizazkar which is in C.

e.g.

\transpose c' d' { \key c \alhizazkar c'4 db' e' f' g' ab' b' }

give's Sahnaz in D.

Sahnaz is therefore redundant. I could delete the entry but commenting
it out maybe a better, long term option for others who may expect to be
able to use 'Sahnaz' as a Makam name.

http://codereview.appspot.com/560950043

Discussion

  • Anonymous

    Anonymous - 2019-08-25
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-08-25

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-08-28
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-08-28

    Patch on countdown for Aug 31st

     
  • Anonymous

    Anonymous - 2019-08-31

    Patch counted down - please push

     
  • Anonymous

    Anonymous - 2019-08-31
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-08-31
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2019-08-31
    ly: hel-arabic - comment out Sahnaz entry staging
    author  Hassan Elfatihi <hassan.elfatihi@free.fr>   
        Sun, 25 Aug 2019 11:40:49 +0100 (11:40 +0100)
    committer   James Lowe <pkx166h@runbox.com> 
        Sat, 31 Aug 2019 17:41:35 +0100 (17:41 +0100)
    commit  6b789abd4674bd160c88207c3bf86a13e28414f8