LilyIssues / Issues / #5524 New function css-color (accompanying x11-color)

Description has changed:

Diff:

--- old
+++ new
@@ -11,29 +11,4 @@
 this. Incidentally, a warning is now issued when the requested color is
 not defined (instead of *silently* falling back to black).

-Only warn about missing color when necessary
-
-
-Merge pull request #6 from rettinghaus/dev/urs/css-fonts
-
-add named colors from CSS Color Module Level 4
-
-Rename x11-color.scm to color.scm
-
-With the previous commit adding `css-color` the file `x11-color.scm` should be
-rename to the generic `color.scm`.
-
-add named colors from CSS Color Module Level 4
-
-
-Define function css-color (accompany x11-color)
-
-It should be possible to specify colors using the CSS names in addition to
-the X11 names.
-
-This commit makes `make-x11-color-handler` generic and adds a function
-`css-color`.
-What remains to be done is (of course documenting and) filling in the remaining
-~140 colors.
-
 http://codereview.appspot.com/570690043

Needs: -->

Urs Liska - 2019-06-03

I will document this when review shows no initial objections against the addition

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Urs Liska - 2019-06-03

Test case:

\override NoteHead.color = #(css-color 'Violet) c'1 \override NoteHead.color = #(x11-color 'DarkCyan) d' }
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-03

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-03

Passes make, make check and a full make doc

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-05

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-05

Patch on countdown for Jun 7th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Urs Liska - 2019-06-05

Patch: countdown --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Urs Liska - 2019-06-05

Discussion showed there are some conceptual issues to discuss.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-05

Needs: -->

Patch: new --> needs_work

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-05

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-05

Reviewers: ,

Message:
This is a follow-up patch to
https://codereview.appspot.com/570690043/

For some reason it was uploaded as a new patch,
and Issue
https://sourceforge.net/p/testlilyissues/issues/5524/
wasn't updated.

This new patch attempts a cleaner separation of color
definitions between X11 and CSS colors, avoiding
duplication.

As with the original patch, I'll document it when
there's basic agreement.

Description:
New function css-color

X11 and CSS colors are now independently accessible through #(x11-color
<name>)
or #(css-color <name>).</name></name>

Both color models are now completely case insensitive (as they should
be),
and spaces are simply stripped from the argument. That way all
combinations
of symbols/strings, CamelCased or lowercase etc. are accepted.

If no color is found by the requested name a warning is issued
(unfortunately that can't be an input warning).

Please review this at https://codereview.appspot.com/580780043/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-05

Patch: needs_work --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-05

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-07

Description has changed:

Diff:

--- old +++ new @@ -11,4 +11,5 @@ this. Incidentally, a warning is now issued when the requested color is not defined (instead of *silently* falling back to black). -http://codereview.appspot.com/570690043 + +https://codereview.appspot.com/580780043/
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-07

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-07

Patch on countdown for June 7th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-09

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-09

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-13

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-15

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-15

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-06-19

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-07-09

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-07-14

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

New function css-color (accompanying x11-color)

Issue Tracker for LilyPond

Searches

Help

#5524 New function css-color (accompanying x11-color)

Discussion