Menu

#5520 Improvements to \ambitusAfter

Fixed
Enhancement
2019-07-12
2019-05-18
Malte Meyn
No

Improvements to \ambitusAfter

• added docstring
• added search for parent Score context for more flexible use
• add \ambitusAfter to Changes

This is the second attempt, the first failed with a timeout error due to my bad internet connection …

http://codereview.appspot.com/552740043

Related

Issues: #4396

Discussion

  • Anonymous

    Anonymous - 2019-05-18
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> needs_work
     
  • Anonymous

    Anonymous - 2019-05-18

    Fails make check

    Renaming input to: `/home/james/lilypond-git/input/regression/ambitus-position.ly'
    Interpreting music.../home/james/lilypond-git/build/out/share/lilypond/current/ly/property-init.ly:46:23: In procedure ly:context-grob-definition in expression (ly:context-grob-definition score (quote BreakAlignment)):
    /home/james/lilypond-git/build/out/share/lilypond/current/ly/property-init.ly:46:23: Wrong type argument in position 1 (expecting Context): #f
    
     
  • Anonymous

    Anonymous - 2019-07-07
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-07-07

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2019-07-09
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-07-09

    Patch on countdown for July 11th

     
  • Anonymous

    Anonymous - 2019-07-11
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-07-11

    Patch counted down - please push.

     
  • Malte Meyn

    Malte Meyn - 2019-07-12
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2019-07-12

    commit 2b52bc2bf1d4d4e505792f074442d4cabb031f06
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sat May 18 11:05:02 2019 +0200

    Issue 5520/2: add \ambitusAfter to Changes
    

    commit 03f4723afcdee9ede15feddacad336d9a067ca8e
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sat May 18 11:04:26 2019 +0200

    Issue 5520/1: Improvements to \ambitusAfter
    
    • added docstring
    • added search for parent Score context for more flexible use
    • added some missing space-alist entries
    
     
  • Malte Meyn

    Malte Meyn - 2019-07-12

    Related: [#4396]

     

    Related

    Issues: #4396