Menu

#5511 add articulation support to multi measure rests

Fixed
Enhancement
2019-04-27
2019-04-19
Malte Meyn
No

add articulation support to multi measure rests

This adds an event type MultiMeasureArticulationEvent and a grob type
MultiMeasureRestScript and allows to add articulations/scripts to multi
measure rests. This means that you can use \fermata now instead of
\fermataMarkup.

\fermataMarkup is deprecated, the regression tests are updated
(convert-ly + manual changes in stencil-scale.ly and multi-measure-rest-text.ly).

http://codereview.appspot.com/562710043

Related

Issues: #5486

Discussion

  • Malte Meyn

    Malte Meyn - 2019-04-19

    Issue [#5486] will wait for this.

     

    Related

    Issues: #5486

  • Malte Meyn

    Malte Meyn - 2019-04-19
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> needs_work
     
  • Malte Meyn

    Malte Meyn - 2019-04-19

    Hm … deprecating \fermataMarkup will break make doc, setting to needs_work.

    And I haven’t added a Changes entry yet.

     
  • Anonymous

    Anonymous - 2019-04-21
    • Needs: -->
    • Patch: new --> needs_work
    • Type: -->
     
  • Anonymous

    Anonymous - 2019-04-21

    Fails make doc.

    You don't comment with '% for texinfo syntax

    See: http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#syntax-survey

    use @c for single line comments or @ignore .. @end ignore for multi line

     
    • Malte Meyn

      Malte Meyn - 2019-04-21

      Oops … I didn’t question Werner’s suggestion on the list (now it’s clear that it was pseudocode) and tested only english and german versions. Mea culpa.

       
  • Werner LEMBERG

    Werner LEMBERG - 2019-04-21

    Sorry! I'm more LaTeX than texinfo user :-)

     
    • Malte Meyn

      Malte Meyn - 2019-04-21

      No problem :) I just should’ve tested at least one document …

       
  • Anonymous

    Anonymous - 2019-04-22
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-04-22

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-04-23
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-04-23

    Patch con countdown for April 27th.

     
  • Anonymous

    Anonymous - 2019-04-27
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-04-27

    Patch counted down - please push to staging.

     
  • Malte Meyn

    Malte Meyn - 2019-04-27
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2019-04-27

    commit 59284fa692be68868e1a69ff7d27689ec1e61b8e
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sat Apr 20 17:10:43 2019 +0200

    Issue 5511/5: doc: Update translated docs
    
    de has a translation of the update, ca/es/fr/it/ja have the offending
    sections commented out and a TODO comment
    

    commit 200658ca20d19cc992baacd9e8694574176cbb92
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Fri Apr 19 14:32:19 2019 +0200

    Issue 5511/4: doc: NR and Changes
    

    commit 453fa92e43df2e70ed4d2555b3bb09b38bedf73f
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Fri Apr 19 13:12:25 2019 +0200

    Issue 5511/3: update regression tests
    
    This is done by convert-ly and a manual change in stencil-scale.ly.
    
    Also, multi-measure-rest-text.ly is changed to demonstrate \fermata and
    \shortfermata.
    

    commit 4424b153c016632e69a7cd7cae6425024cee49fb
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Fri Apr 19 12:15:57 2019 +0200

    Issue 5511/2: deprecate \fermataMarkup
    
    This removes \fermataMarkup and adds a convert-ly rule.
    

    commit 8d7c176b4555d2da62e09b88a3295a45a0348e01
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Fri Apr 19 12:09:40 2019 +0200

    Issue 5511/1: add articulation support to MMRs
    
    This adds an event type MultiMeasureArticulationEvent and a grob type
    MultiMeasureRestScript and allows to add articulations/scripts to multi
    measure rests. This means that you can use \fermata now instead of
    \fermataMarkup.