Menu

#5496 Clean up problems with fret-diagram-terse markups

Fixed
Enhancement
2019-03-30
2019-03-14
No

Clean up problems with fret-diagram-terse markups

Clarify that only one indication per string can be created with
fret-diagram-terse syntax.
Add warning to fret-parse-terse-definition-string when a barre
is ended on a fret without being started on that fret.

As this does not change the allowed syntax, I do not feel a regtest
is necessary.

The warning can be seen by executing the following code:
\version "2.19.82"

\markup {
\fret-diagram-terse "x;o;o;5-1-(;5-1;7-3-);"
}

http://codereview.appspot.com/546560043

Discussion

  • Anonymous

    Anonymous - 2019-03-16
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-03-16

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-03-18
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-03-18

    Patch on countdown for March 21st.

     
  • Anonymous

    Anonymous - 2019-03-21
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-03-21

    Patch counted down - please push to staging.

     
  • Anonymous

    Anonymous - 2019-03-24
     
  • Anonymous

    Anonymous - 2019-03-24

    Patch counted down - please push to staging.

     
  • Anonymous

    Anonymous - 2019-03-27

    Patch counted down - please push to staging.

     
  • Carl Sorensen

    Carl Sorensen - 2019-03-30
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Carl Sorensen

    Carl Sorensen - 2019-03-30

    Pushed to staging as
    45dedd4..6508284