Menu

#5495 Add warning message for unknown code in fret-diagram-verbose

Fixed
Enhancement
2019-03-30
2019-03-14
No

Add warning message for unknown code in fret-diagram-verbose

This patch does not change the printed or midi output; it only
generates a warning on the console and in the logfile. Because
there is no change to the printed output, I felt like there was
no need for a regression test.

You can see the effect of this patch by running the following code:

\version "2.19.82"

{
s1^\markup{
\fret-diagram-verbose #'(
(please harakiri 1 5)
)
}
}

which will create a blank fret diagram and print a warning message in the
log.

http://codereview.appspot.com/570540043

Discussion

  • Anonymous

    Anonymous - 2019-03-14
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-03-14

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-03-16
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-03-16

    Patch on countdown for March 18th

     
  • Carl Sorensen

    Carl Sorensen - 2019-03-18

    New patch uploaded responding to Harm's comments; git-cl updated the status but didn't record the message.

     
  • Anonymous

    Anonymous - 2019-03-18
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-03-18

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-03-21
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-03-21

    Patch on countdown for March 24th

     
  • Anonymous

    Anonymous - 2019-03-24
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-03-24

    Patch counted down - please push to staging.

     
  • Anonymous

    Anonymous - 2019-03-27

    Patch counted down - please push to staging.

     
  • Carl Sorensen

    Carl Sorensen - 2019-03-30

    Pushed to staging as 1b1b06d..45dedd4

     
  • Carl Sorensen

    Carl Sorensen - 2019-03-30
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->