#5493 Add a procedure to add slashes to Beams and straight Flags

[Thomas Morley]

Add a procedure to add slashes to Beams and straight Flags

Adds procedure slash-stencil to stencil.scm
Replaces add-stroke-straight from flag-styles.scm with slash-stencil.
Amends defs in grace-init.ly with slashedBeam.
Amends Beam.details. Creates Flag.details.
Documentation and regtest.

http://codereview.appspot.com/562550043

[Thomas Morley]

The patch for this issue tries to do more than #1333 requests, thus I opened a new issue. If accepted issue 1333 should be closed.

[Thomas Morley]

The patch contains a snippet in Documentation/snippets/new
Should I run
scripts/auxiliar/makelsr.py
?
I forgot what's our current policy...

[Malte Meyn]

I forgot too but you could have a look at the discussions (issue tracker and mailing list) about issue 5251, where I added a snippet to LSR.

[Thomas Morley]

Hi Malte,
I've read up makelsr
As opposed to your patch this one updates an already existing snippet. Thus the patch can stand alone.
I think I'll run makelsr afterwards. And commit/push, if all's ok.

[Anonymous]

Fails make doc.

% ****************************************************************
% ly snippet:
% ****************************************************************
\sourcefileline 65
{ \acciaccatura { b'16 c'' } d''4 }

@item
A very short fermata and Henze variants of long and short fermatas
have been added.
@lilypond[quote]
\markup {
  \musicglyph "scripts.uveryshortfermata"
  \musicglyph "scripts.uhenzelongfermata"
  \musicglyph "scripts.uhenzeshortfermata"
}

% ****************************************************************
% end ly snippet
% ****************************************************************

returns

...
5e.ly:68:1: error: bad expression type

@item
././ac/lily-9b24b45e.ly:69:1: error: syntax error, unexpected SYMBOL, expecting '.' or '='

A very short fermata and Henze variants of long and short fermatas
././ac/lily-9b24b45e.ly:71:1: error: not a key

@lilypond[quote]
././ac/lily-9b24b45e.ly:71:2: error: syntax error, unexpected SYMBOL, expecting '='
@
 lilypond[quote]
Interpreting music...
Preprocessing graphical objects...
Calculating line breaks... 
Drawing systems... 
Writing ./ac/lily-9b24b45e-1.signature
Writing ./ac/lily-9b24b45e-2.signature
Layout output to `./ac/lily-9b24b45e.eps'...
Converting to `./ac/lily-9b24b45e.pdf'...
Converting to PNG...
Layout output to `./ac/lily-9b24b45e-1.eps'...
Layout output to `./ac/lily-9b24b45e-2.eps'...
Converting to `./ac/lily-9b24b45e-1.pdf'...
Converting to `./ac/lily-9b24b45e-2.pdf'...
Writing ./ac/lily-9b24b45e-systems.texi...
Writing ./ac/lily-9b24b45e-systems.tex...
Writing ./ac/lily-9b24b45e-systems.count...
fatal error: failed files: "ac/lily-9b24b45e.ly"
fatal error: Children (0) exited with errors.

[Malte Meyn]

@end lilypond is missing here.

[Thomas Morley]

Done.
Thanks.

[Anonymous]

Passes make, make check and a full make doc

[Anonymous]

Passes make. make check and a full make doc.

[Anonymous]

Patch on countdown for March 18th

[Thomas Morley]

Setting to 'needs-work', see my comment on Rietvled

[Thomas Morley]

Setting to 'needs-work', see my comment on Rietvled