• rename trilelement → trillelement
• fix erroneous shape of pralldown/prallup
• enlarge arc of downprall/pralldown
• move and shorten line of lineprall
(although I don't know why I am not seeing any extra diffs - do we not reg test these glyphs anywhere?)
No, we don’t, only \prall is used in some regtests. Would the normal regtests show differences? I thought they only show differences in positioning, not in appearance of grobs/glyphs.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
(although I don't know why I am not seeing any extra diffs - do we
not reg test these glyphs anywhere?)
No, we don’t, only \prall is used in some regtests. Would the normal
regtests show differences? I thought they only show differences in
positioning, not in appearance of grobs/glyphs.
They show the difference in appearance (they are graphical comparisons
after all). But only when triggered by a difference in
positioning/metrics.
--
David Kastrup
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2019-03-04
Needs: -->
Patch: new --> review
Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2019-03-04
Passes make, make check and a full make doc.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2019-03-06
Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2019-03-06
Patch on countdown for March 9th
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2019-03-09
Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2019-03-09
Patch counted down - please push to staging.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
commit 56942ccc5f5a7ac0088b16e3f7d28ff6bffc530d
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sun Mar 3 09:57:10 2019 +0100
Issue 5489/2: rename trilelement → trillelement
including convert-ly rule
commit 2afb45bd85d85ddd06855aa3eea730d72581444c
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sun Mar 3 09:47:56 2019 +0100
Issue 5489/1: improve prall glyphs
• fix erroneous shape of pralldown/prallup
• enlarge arc of downprall/pralldown
• move and shorten line of lineprall
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
"pkx166h" lilypond-pkx@users.sourceforge.net writes:
Our regtests only trigger for new metrics, not new visuals. So you only
get to see new visuals in comparisons if the metrics changed as well.
--
David Kastrup
Passes make, make check and a full make doc.
(although I don't know why I am not seeing any extra diffs - do we not reg test these glyphs anywhere?)
No, we don’t, only
\prallis used in some regtests. Would the normal regtests show differences? I thought they only show differences in positioning, not in appearance of grobs/glyphs."Malte Meyn" maltem@users.sourceforge.net writes:
They show the difference in appearance (they are graphical comparisons
after all). But only when triggered by a difference in
positioning/metrics.
--
David Kastrup
Passes make, make check and a full make doc.
Patch on countdown for March 9th
Patch counted down - please push to staging.
commit 56942ccc5f5a7ac0088b16e3f7d28ff6bffc530d
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sun Mar 3 09:57:10 2019 +0100
commit 2afb45bd85d85ddd06855aa3eea730d72581444c
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sun Mar 3 09:47:56 2019 +0100