Menu

#5487 add very short and Henze fermatas

Fixed
Enhancement
2019-03-09
2019-03-01
Malte Meyn
No

add very short and Henze fermatas

These were missing for SMuFL compliance.

http://codereview.appspot.com/347080043

Related

Issues: #5486

Discussion

  • Anonymous

    Anonymous - 2019-03-01
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> needs_work
     
  • Anonymous

    Anonymous - 2019-03-01

    Fails make doc

    Looking at a multirun.log file (the normal console output points to a file with just running job PIDs) I can see the only file containing a compile error shows this:

    ...
    Processing `./3d/lily-d937fff8.ly'
    Parsing...
    Interpreting music...
    warning: do not know how to interpret articulation:
    warning:  scheme encoding: 
    warning: do not know how to interpret articulation:
    warning:  scheme encoding: 
    warning: do not know how to interpret articulation:
    warning:  scheme encoding: 
    [8][8]
    Preprocessing graphical objects...lilypond: /home/james/lilypond-git/lily/script-interface.cc:36: static Stencil Script_interface::get_stencil(Grob*, Direction): Assertion `scm_is_pair (s)' failed.
    

    If I look up that file ./3d/lily-d937fff8.ly I get this:

    %% Generated by lilypond-book.py
    %% Options: [exampleindent=10.16\mm,indent=0\mm,line-width=160\mm,quote]
    \include "lilypond-book-preamble.ly"
    
    % ****************************************************************
    % Start cut-&-pastable-section
    % ****************************************************************
    
    \paper {
      indent = 0\mm
      line-width = 160\mm
      % offset the left padding, also add 1mm as lilypond creates cropped
      % images with a little space on the right
      line-width = #(- line-width (* mm  3.000000) (* mm 1))
      line-width = 160\mm - 2.0 * 10.16\mm
      % offset the left padding, also add 1mm as lilypond creates cropped
      % images with a little space on the right
      line-width = #(- line-width (* mm  3.000000) (* mm 1))
    }
    
    \layout {
    
    }
    
    % ****************************************************************
    % ly snippet:
    % ****************************************************************
    \sourcefileline 1323
    \include "script-chart.ly"
    \new RhythmicStaff { \scriptStaff #fermatas }
    
    % ****************************************************************
    % end ly snippet
    % ****************************************************************
    
     
  • Malte Meyn

    Malte Meyn - 2019-03-02

    I’m sorry. I thought I had to add the new glyphs to script-chart.ly. But it seems like something is missing there, maybe script commands like \veryshortfermata. Maybe we should update this part of the german translation so that the file script-chart.ly isn’t needed anymore.

    I’ll upload a next patchset that simply doesn’t add the new fermatas to script-chart.ly.

     
  • Anonymous

    Anonymous - 2019-03-03
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-03-03

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-03-06
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-03-06

    Patch on countdown for March 9th

     
  • Anonymous

    Anonymous - 2019-03-09
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-03-09

    Patch counted down - please push to staging.

     
  • Malte Meyn

    Malte Meyn - 2019-03-09
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2019-03-09

    commit 77b98cbbc6093b45e3e9040532e7bce38ffd0db4
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Fri Mar 1 10:33:10 2019 +0100

    Issue 5487/2: add new fermatas to Changes doc
    

    commit 1284c743b02c16e77cd47aac10c590aee1ba66dc
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Thu Feb 28 21:38:37 2019 +0100

    Issue 5487/1: add very short and Henze fermatas
    
    These were missing for SMuFL compliance.
    This contains the addition of the fermatas to encodingdefs.ps.
    
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.