#5486 add fermata markup commands

[Malte Meyn]

add fermata markup commands

Like the markup command \fermata and \fermataMarkup there are now:
\shortfermata, \longfermata, \verylongfermata
\shortfermataMarkup, \longfermataMarkup, \verylongfermataMarkup

contains also: add fermata markup commands to docs

http://codereview.appspot.com/344160043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Passes make, make check and a full make doc.

[Malte Meyn]

Waiting for [#5487], probably needs some more discussion.

[Thomas Morley]

Based on my suggestion here:
https://codereview.appspot.com/344160043/#msg5
you'll find an elaborated code attached.

[Thomas Morley]

Well, style should be a symbol not a string...

[Malte Meyn]

Setting to needs_work for the following reasons:

• very short and Henze fermatas need commands too
• there is discussion on Rietveld about making a single versatile command for all fermata types
• needing \fermataMarkup instead of \fermata for MultiMeasureRests is unintuitive, maybe we can make one command that works both for Rests and MultiMeasureRests
• I don’t have time until April or May to do anything of the above

[Malte Meyn]

• needing \fermataMarkup instead of \fermata for MultiMeasureRests is unintuitive, maybe we can make one command that works both for Rests and MultiMeasureRests

[#5511] tries to solve that problem.

[Malte Meyn]

Now that [#5511] is solved I’m not sure we need markup commands for all fermata types. Do we? If someone wants to write \markup \column { "ad lib." \longfermata } couldn’t they just use \markup \column { "ad lib." \musicglyph #"scripts.longfermata" }? You wouldn’t have automatic directions then. But to me it seems as if adding six new markup commands or a single fermata markup command that can do fermatas but not other scripts much effort for little benefit.

[Anonymous]

This fails make doc

fatal error: Unlisted scripts in Documentation/included/script-chart.ly: (henzelongfermata henzeshortfermata veryshortfermata)

I am guessing that you might need to add these strings in the 'define fermatas' section for these new fermatas (from line #65 of this file).

[Malte Meyn]

Damn. I’ll probably never learn that, sorry :( I did a make doc but only for the english version. Maybe I should just replace that script-chart.ly thing from the german documentation (the only translation that still uses it) by whatever the english version does.

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for May 3rd.

[Anonymous]

Patch counted down - please push to staging.

[Malte Meyn]

commit c9286e87ee523fcfb9a4501c75490834306bdb2b
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sun Apr 28 15:01:41 2019 +0200

Issue 5486/2: add fermata commands to NR

commit ff348fa75a77cc31832d321316e0a3230e2b0243
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sun Apr 28 10:10:06 2019 +0200

Issue 5486/1: add very short/Henze fermata commands