LilyIssues / Issues / #5485 undefined operation (GCC warning) in page-turn-page-breaking.cc

#5485 undefined operation (GCC warning) in page-turn-page-breaking.cc

Status: Fixed

Owner: Malte Meyn

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2019-03-06

Created: 2019-02-25

Creator: Valentin Villenave

Private: No

This has been verified by multiple persons:

page-turn-page-breaking.cc: In instantiation of 'bool is_break(T*) [with T =
Grob]':
page-turn-page-breaking.cc:50:54:   required from here
page-turn-page-breaking.cc:38:3: warning: operation on '*0' may be undefined
[-Wsequence-point]
   if (turnable
   ^~
page-turn-page-breaking.cc: In instantiation of 'bool is_break(T*) [with T =
Prob]':
page-turn-page-breaking.cc:50:54:   required from here
page-turn-page-breaking.cc:38:3: warning: operation on '*0' may be undefined
[-Wsequence-point]

https://codereview.appspot.com/351880043

Discussion

Malte Meyn - 2019-02-28

status: Accepted --> Started

assigned_to: Malte Meyn
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-02-28

Description has changed:

Diff:

--- old +++ new @@ -14,3 +14,5 @@ page-turn-page-breaking.cc:38:3: warning: operation on '*0' may be undefined [-Wsequence-point] ~~~ + +https://codereview.appspot.com/351880043

Needs: -->

Type: --> Build
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-03-01

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-03-01

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-03-03

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-03-03

Patch on countdown for March 6th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-03-06

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-03-06

Patch counted down - please push to staging

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-03-06

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-03-06

commit 5eb392ddd5f78dd7a071d48b1f6ab6e859b6dc8d
Author: Malte Meyn lilypond@maltemeyn.de
Date: Thu Feb 28 13:48:11 2019 +0100

Issue 5485: avoid -Wsequence-point warning
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

undefined operation (GCC warning) in page-turn-page-breaking.cc

Issue Tracker for LilyPond

Searches

Help

#5485 undefined operation (GCC warning) in page-turn-page-breaking.cc

Discussion