Menu

#5471 Improve relocation debug messages.

Fixed
Enhancement
2019-02-08
2019-01-31
No

Improve relocation debug messages.

This patch contains the following commits.

  • relocate.cc: Don't use double forward slashes in file names.

  • main.cc, relocate.cc: Improve relocation debug messages.

This commit does the following.

  • Add `_f ()' where necessary.
  • Improve readability of code by omitting some `.c_str ()' conversions.
  • Synchronize formatting of messages.
  • Improve messages to make the more readable. Also add some new ones.
  • Indent all messages related to relocation.

  • relocate.cc: Add indent' parameter tosane_putenv'.

We are going to use that to provide better formatting of debug messages.

http://codereview.appspot.com/347070043

Discussion

  • Anonymous

    Anonymous - 2019-02-01
    • Description has changed:

    Diff:

    
    
    • assigned_to: Werner LEMBERG
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2019-02-01

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-02-04
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-02-04

    Patch on countdown for Feb 7th

     
  • Anonymous

    Anonymous - 2019-02-07

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2019-02-07
    • Patch: countdown --> push
     
  • Werner LEMBERG

    Werner LEMBERG - 2019-02-08

    Pushed to staging as

    commit 19da23977f5842564cc9b63992a5c23eb7ef9dda (HEAD -> staging, origin/staging, relocate-doc)
    Author: Werner Lemberg wl@gnu.org
    Date: Thu Jan 31 18:51:45 2019 +0100

    Issue 5471/3: relocate.cc: Don't use double forward slashes in file names
    

    commit d6428b77b62b8663def0d1b33f60d2078c1e02bd
    Author: Werner Lemberg wl@gnu.org
    Date: Thu Jan 31 18:46:40 2019 +0100

    Issue 5471/2: main.cc, relocate.cc: Improve relocation debug messages
    
    This commit does the following.
    
    
    * Add `_f ()' where necessary.
    * Improve readability of code by omitting some `.c_str ()' conversions.
    * Synchronize formatting of messages.
    * Improve messages to make them more readable.  Also add some new ones.
    * Indent all messages related to relocation.
    

    commit ef2cc5e684a5583ae1266281159fc1ef27e0e923
    Author: Werner Lemberg wl@gnu.org
    Date: Thu Jan 31 18:39:10 2019 +0100

    Issue 5471/1: relocate.cc: Add `indent' parameter to `sane_putenv'
    
    We are going to use that to provide better formatting of debug messages.
    
     
  • Werner LEMBERG

    Werner LEMBERG - 2019-02-08
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
MongoDB Logo MongoDB