LilyIssues / Issues / #5467 Fix make check without extractpdfmark

summary: Change font path loaded by EPS file when -dfont-export-dir --> Fix make check without extractpdfmark
Description has changed:

Diff:

--- old
+++ new
@@ -1,24 +1,24 @@
-Change font path loaded by EPS file when `-dfont-export-dir`
+Issue 5467/3: Change font path loaded by EPS file when `-dfont-export-dir`

-With LilyPond's commandline option `-dfont-export-dir`,
-outputted PS / EPS files used absolute font path when font loading
-by Ghostscript was requested.
+  With LilyPond's commandline option `-dfont-export-dir`,
+  outputted PS / EPS files used absolute font path when font loading
+  by Ghostscript was requested.

-This commit makes they always use relative font path
-from `lilypond-datadir` same as without the `-dfont-export-dir` option.
+  This commit makes they always use relative font path
+  from `lilypond-datadir` same as without the `-dfont-export-dir` option.

-Define `lilypond-datadir` in exported font PS files
+Issue 5467/2: Define `lilypond-datadir` in exported font PS files

-Exported font PS files didn't define `lilypond-datadir`.
-However, to use relative font path, we need the define.
+  Exported font PS files didn't define `lilypond-datadir`.
+  However, to use relative font path, we need the define.

-This commit makes define `lilypond-datadir` in the PS files.
+  This commit makes define `lilypond-datadir` in the PS files.

-Fix `make check` without extractpdfmark
+Issue 5467/1: Fix `make check` without extractpdfmark

-Without extractpdfmark,
-`make check` failed because `output-distance.py` specified
-the relative path from wrong origin for Ghostscript.
-This commit makes `output-distance.py` specify correct absolute path.
+  Without extractpdfmark,
+  `make check` failed because `output-distance.py` specified
+  the relative path from wrong origin for Ghostscript.
+  This commit makes `output-distance.py` specify correct absolute path.

 http://codereview.appspot.com/349110043

Needs: -->

Masamichi Hosoda - 2019-01-24

http://lists.gnu.org/archive/html/lilypond-devel/2019-01/msg00113.html

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-01-25

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-01-25

Passes make, make check and a full make doc as a normal patch.

I also was able to make check with this patch when I didn't have extractpdfmark in the PATH.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2019-01-25

Use abs_dir --- this requires Issue 5466

http://codereview.appspot.com/349110043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2019-01-25

I've uploaded Patch Set 2.
This patch requires Werner's Issue 5466.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-01-26

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-01-26

Passes make, make check and a full make doc all without using extractpdfmark

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-01-29

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-01-29

Patch on countdown for Feb 1st

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-02-01

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-02-01

Patch counte d down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2019-02-01

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Masamichi Hosoda - 2019-02-01

I've pushed to staging.

commit a64b4dbc92ac0bbece08043349a55dccd84f4fd7
Issue 5467/3: Change font path loaded by EPS file when -dfont-export-dir

commit b0300944e015b5957e50441224699e55c68c3dc3
Issue 5467/2: Define lilypond-datadir in exported font PS files

commit f76997b5097f588060f823c4c87f01bac9f2fe50
Issue 5467/1: Fix make check without extractpdfmark

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fix make check without extractpdfmark

Issue Tracker for LilyPond

Searches

Help

#5467 Fix make check without extractpdfmark

Discussion