Menu

#5464 New feature: automatically invert chords or drop/rise chord notes

Fixed
push
Enhancement
2019-02-14
2019-01-19
No

New feature: automatically invert chords or drop/rise chord notes

This feature was suggested and improved upon by
Davide Bonetti, with some help from David K:
https://lists.gnu.org/archive/html/lilypond-user/2019-01/msg00360.html

Included here are three new commands: \dropNote, \riseNote and
\invertChords, and a new Scheme function, move-chord-note.
The first two commands take an integer that selects which
note will be transposed one octave lower or higher within
every chord in the music expression that follows, thus allowing
for more sophisticated voicings (e.g. `drop 2’ and the like).
If the argument is out of range (if there aren’t enough notes
in the chord), it’s silently ignored and the chord’s left unchanged.

\invertChords accepts both positive and negative integers, and
inverts all chords accordingly (as in switching the root note’s
position, not as in reversing intervals like \inversion does).

These commands work with both explicitely-written chords and
\chordmode-entered chords (only when printed on a staff though;
ChordNames are not to be affected).

http://codereview.appspot.com/365840043

Discussion

  • Anonymous

    Anonymous - 2019-01-22
    • Needs: -->
    • Patch: new --> needs_work
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-01-22

    Valentin, you need to rebase - patch doesn't apply

    error: patch failed: Documentation/included/gsoc.itexi:240
    error: Documentation/included/gsoc.itexi: patch does not apply
    /home/james/Desktop/issuexxx.diff:213: new blank line at EOF.
    +
    /home/james/Desktop/issuexxx.diff:395: new blank line at EOF.
    +
    

    Probably due to the pushed commit yesterday

    http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=88fac37543533aa3ad24852915055ef6394a509d

     
  • Anonymous

    Anonymous - 2019-01-23
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-01-23

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2019-01-24
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-01-24

    Passes make, make check and a full make doc - although there are some new comments in Rietveld from David.

     
  • Anonymous

    Anonymous - 2019-01-26

    Leaving on Review. There are some new comments in Rietveld from David.

     
  • Anonymous

    Anonymous - 2019-01-29
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-01-29

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-01-31
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-01-31

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-02-01
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-02-01

    Patch on countdown for Feb 4th.

     
  • Anonymous

    Anonymous - 2019-02-04
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2019-02-04

    passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2019-02-07
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2019-02-07

    Patch on countdown for Feb 10th although there is a comment on Rietveld that you may want to address.

     
  • Anonymous

    Anonymous - 2019-02-10
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2019-02-10

    Patch counted down - please push.

     
  • Valentin Villenave

    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed