Menu ▾ ▴

#5450 relocate.cc: Introduce new command `set?'.

Fixed
Werner LEMBERG
Fixed_2_21_0 (565)
Enhancement
2018-12-30
2018-12-21
Werner LEMBERG
No

relocate.cc: Introduce new command set?.

Contrary to set, set? won't override environment variables that are
already set.

We need this for reproducable builds, in particular with gub: The standard
fontconfig setup includes font files like ~/.fonts or /usr/share, which
obviously must not be used. Up to now, the fontconfig.reloc file in gub
uses the set relocation command, which doesn't allow gub to replace the
fontconfig configuration file with a temporary alternative while building
test files or documentation. Future changes in gub will use set? instead.

http://codereview.appspot.com/345160043

Discussion

  • Werner LEMBERG

    Werner LEMBERG - 2018-12-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,13 +1,13 @@
-relocate.cc: Introduce new command `set?'.
+relocate.cc: Introduce new command `set?`.

-Contrary to `set', `set?' won't override environment variables that are
+Contrary to `set`, `set?` won't override environment variables that are
 already set.

 We need this for reproducable builds, in particular with gub: The standard
-fontconfig setup includes font files like `~/.fonts' or `/usr/share', which
-obviously must not be used.  Up to now, the `fontconfig.reloc' file in gub
-uses the `set' relocation command, which doesn't allow gub to replace the
+fontconfig setup includes font files like `~/.fonts` or `/usr/share`, which
+obviously must not be used.  Up to now, the `fontconfig.reloc` file in gub
+uses the `set` relocation command, which doesn't allow gub to replace the
 fontconfig configuration file with a temporary alternative while building
-test files or documentation.  Future changes in gub will use `set?' instead.
+test files or documentation.  Future changes in gub will use `set?` instead.

 http://codereview.appspot.com/345160043
    • Needs: -->
     

  • Anonymous

    Anonymous - 2018-12-22
    • assigned_to: Werner LEMBERG
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2018-12-22

    Passes make. make check and a full make doc.

     

  • Anonymous

    Anonymous - 2018-12-24
    • Patch: review --> needs_work
     

  • Anonymous

    Anonymous - 2018-12-24

    Needs more tidying up (see Rietveld)

     

  • Werner LEMBERG

    Werner LEMBERG - 2018-12-24

    Needs more tidying up (see Rietveld)

    Perhaps a misunderstanding: My Rietveld comment #6 was a response to David, it is not related to the patch itself, which is OK and ready to push. I will prepare a follow-up patch.

     

  • Werner LEMBERG

    Werner LEMBERG - 2018-12-24
    • Patch: needs_work --> review
     

  • Anonymous

    Anonymous - 2018-12-27
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2018-12-27

    Patch on countdown for Dec 30th

     

  • Anonymous

    Anonymous - 2018-12-30
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2018-12-30

    Patch counted down. Please push.

     

  • Werner LEMBERG

    Werner LEMBERG - 2018-12-30

    Pushed to staging as
    commit 8067320145662554d85e59e6b9e6df3770f9e4a3
    Author: Werner Lemberg wl@gnu.org
    Date: Fri Dec 21 17:47:11 2018 +0100

    Issue 5450: relocate.cc: Introduce new command `set?'

Contrary to `set', `set?' won't override environment variables that are
already set.

We need this for reproducable builds, in particular with gub: The standard
fontconfig setup includes font files like `~/.fonts' or `/usr/share', which
obviously must not be used.  Up to now, the `fontconfig.reloc' file in gub
uses the `set' relocation command, which doesn't allow gub to replace the
fontconfig configuration file with a temporary alternative while building
test files or documentation.  Future changes in gub will use `set?' instead.
     

  • Werner LEMBERG

    Werner LEMBERG - 2018-12-30
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
MongoDB Logo MongoDB