LilyIssues / Issues / #5446 ly: updates to hel-arabic.ly

#5446 ly: updates to hel-arabic.ly

Status: Fixed

Owner:

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2019-02-01

Created: 2018-12-12

Creator:

Private: No

ly: updates to hel-arabic.ly

Changes suggested by Hassan Elfatihi

Minor Typos fixed

irak, rahatalarouah and alboustankar
are all redundant as they are all the same
mode as 'rast'.

Sajkar mode is never used so this has been
removed.

http://codereview.appspot.com/349810043

Discussion

Anonymous - 2018-12-12

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-12

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-15

Comments to address on Rietveld.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-17

New patch created

0001-ly-updates-to-hel-arabic.ly.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-17

Needs: -->

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-17

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-21

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-21

Patch on countdown for Dec 24th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-24

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-24

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-12-24

labels: --> Fixed_2_21_0

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

author  Hassan Elfathi <hassan.elfatihi@free.fr>    
    Wed, 12 Dec 2018 08:19:18 +0000 (08:19 +0000)
committer   James Lowe <pkx166h@runbox.com> 
    Mon, 24 Dec 2018 10:40:01 +0000 (10:40 +0000)
commit  bb5af856e09b4008f3a6e5ff8c13c34b239ae6b9

Malte Meyn - 2019-02-01

status: Started --> Fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ly: updates to hel-arabic.ly

Issue Tracker for LilyPond

Searches

Help

#5446 ly: updates to hel-arabic.ly

Discussion