LilyIssues / Issues / #5438 Give \key command a better predicate for scale type

Issue Tracker for LilyPond

#5438 Give \key command a better predicate for scale type

Status: Fixed

Owner: David Kastrup

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2018-11-23

Created: 2018-11-14

Creator: David Kastrup

Private: No

Give \key command a better predicate for scale type

{ \key c major }

should not be accepted at the parsing state, turning "major" into
'(major) matching the list? predicate. So instead a number-pair-list?
predicate is being used which is much less likely to be matched by
erroneous input.

http://codereview.appspot.com/357840043

Discussion

Anonymous - 2018-11-15

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-15

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-17

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-17

Patch on countdown for Nov 21

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-20

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-20

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-23

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

author  David Kastrup <dak@gnu.org> 
    Wed, 14 Nov 2018 09:40:32 +0000 (10:40 +0100)
committer   David Kastrup <dak@gnu.org> 
    Tue, 20 Nov 2018 11:45:06 +0000 (12:45 +0100)
commit  6e41e18663c79389ee96f9662ad7b760b2e08667

Give \key command a better predicate for scale type

Issue Tracker for LilyPond

Searches

Help

#5438 Give \key command a better predicate for scale type

Discussion