Use a stable sort when ordering MIDI items

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#5434 Use a stable sort when ordering MIDI items

Status: Fixed

Owner: Boris-Chengbiao Zhou

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2018-11-06

Created: 2018-10-31

Creator: Boris-Chengbiao Zhou

Private: No

Use a stable sort when ordering MIDI items

Fixes the issue described here:
https://lists.gnu.org/archive/html/lilypond-user/2015-02/msg00035.html
(undeterministic reordering of events at the same MIDI timestamp; e.g.
"\sustainOff\sustainOn")

http://codereview.appspot.com/353790043

1 Attachments

0001-Use-a-stable-sort-when-ordering-MIDI-items.patch

Discussion

Anonymous - 2018-10-31

Description has changed:

Diff:

Needs: -->

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-10-31

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-02

Patch: review --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-02

This looks like there is some work that needs to be done (reg test as part of the patch? which 'sort' functiohn to use?). I am setting this back to 'Needs_work'.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-03

Patch: needs_work --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-03

Patch on countdown for Nov 5th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-05

Patch counted down please push.

Boris if you don't have commit access can you make a git formatted patch based on current master and I can push it on your behalf.

Attach it to this ticket

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-05

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Boris-Chengbiao Zhou - 2018-11-05

Attachments has changed:

Diff:

--- old +++ new @@ -0,0 +1 @@ +0001-Use-a-stable-sort-when-ordering-MIDI-items.patch (1.7 kB; text/x-patch)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Boris-Chengbiao Zhou - 2018-11-05

Yeah, please push the patch for me. I've attached it. Thanks in advance.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Boris-Chengbiao Zhou - 2018-11-06

status: Started --> Fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Boris-Chengbiao Zhou - 2018-11-06

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-06

labels: --> Fixed_2_21_0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-11-06

author Boris-Chengbiao Zhou <bobo1239@web.de> Wed, 31 Oct 2018 02:34:04 +0000 (03:34 +0100) committer James Lowe <pkx166h@runbox.com> Tue, 6 Nov 2018 08:16:58 +0000 (08:16 +0000) commit 86de0f8f38a90e5697fb1cb8e79b04ef4eee5e2d

Thank you Boris
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: