#5424 GUB: glib patch needed to compile with gcc >=6.x.y

[Federico Bruni]

This is a GUB issue.
When launching 'make lilypond' on Fedora 28, gcc version 8.1, I get this error:

/home/dev/gub/target/tools/src/glib-2.44.1/glib/gdate.c: In function 'g_date_strftime':
/home/dev/gub/target/tools/src/glib-2.44.1/glib/gdate.c:2497:7: error: format not a string literal, format string not checked [-Werror=format-nonliteral]
       tmplen = strftime (tmpbuf, tmpbufsize, locale_format, &tm);
       ^~~~~~

This commit provides the solution.

I guess that adding a patch to GUB patches/ directory is the way to go.

This issue seems to suggest that the error started with gcc 6.2.1.

[Federico Bruni]

Sent a PR on Github: https://github.com/gperciva/gub/pull/47
The actual commit to be reviewed is this one: https://github.com/gperciva/gub/pull/47/commits/a02d9ac2c4fba422d42b2d0d32dff58e6d0b67cc

Now I'll see how to upload it to Rietveld for review...

[Federico Bruni]

https://codereview.appspot.com/341500043/

[Anonymous]

I guess I personally cannot 'test' this so am setting this to review (unles ssomeone else can run GUB to test?)

[Anonymous]

Patch on countdown for Oct 12th

[Anonymous]

Patch counted down - please 'push'.

[Phil Holmes]

I believe this has now been fixed with my merge pull today.