#5415 Fix type-conversion warnings in parser and lexer

[Dan Eble]

Fix type-conversion warnings in parser and lexer

in two commits:

• lexer: move repeated code into a skip_chars() method. In passing,
  fix type-conversion warnings produced by g++ 8.0.1 on x86_64.

• fix some parsing type-conversion warnings observed with g++ 8.0.1 on
  x86_64

http://codereview.appspot.com/348990043

[Anonymous]

Passes make, make check and a full make doc.

[Dan Eble]

response to feedback

http://codereview.appspot.com/348990043

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for Sept 16th

[Anonymous]

Patch counted down - please push.

[Dan Eble]

commit aa84b5db2a2313f4eed217736294eaa9a2a9fe38 (HEAD -> pushed/issue-5415-warnings-lexer-parser, origin/staging)
Author: Dan Eble nine.fierce.ballads@gmail.com
Date: Sat Sep 8 14:52:03 2018 -0400

Issue 5415/2: lexer: move repeated code into a skip_chars() method

In passing, fix type-conversion warnings produced by g++ 8.0.1 on
x86_64.

commit 2ec8daced78ac5e40f8b38da38c0fb37296ea3bf
Author: Dan Eble nine.fierce.ballads@gmail.com
Date: Sat Sep 8 09:44:19 2018 -0400

Issue 5415/1: fix some parsing type-conversion warnings
observed with g++ 8.0.1 on x86_64


1. Remove a condition in MYBACKUP that serves no current purpose.  The
compiler warned about using an enum in bool context.


2. Change the result of Keyword_table::lookup() from vsize to int.
The source data is an int and the caller was converting the vsize back
to int.  The compiler warned about the latter.