Menu

#5410 Fix warnings in flower

Fixed
Dan Eble
Build
2018-09-14
2018-09-04
Dan Eble
No

Fix warnings in flower coming from g++ 8.0.1 on x86_64.
http://codereview.appspot.com/346930044

Discussion

  • Anonymous

    Anonymous - 2018-09-06
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2018-09-06

    Pasees make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2018-09-10
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-09-10

    Patch on countdown for Sept 13th

     
  • Anonymous

    Anonymous - 2018-09-13
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-09-13

    Patch counted down - please push

     
  • Dan Eble

    Dan Eble - 2018-09-14
    • labels: --> Fixed_2_21_0
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,9 +1,2 @@
    -Fix warnings in flower
    -... coming from g++ 8.0.1 on x86_64.
    -
    -Three commits:
    -* remove unused memrchr and memrev
    -* remove unused Polynomial::set_mod
    -* fix remaining int/size conversion warnings
    -
    +Fix warnings in flower coming from g++ 8.0.1 on x86_64.
     http://codereview.appspot.com/346930044
    
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Build
     
  • Dan Eble

    Dan Eble - 2018-09-14

    commit 5118a7f6fdffe4ff8a1e283f755b403c20e41597 (HEAD -> pushed/issue-5410-warnings-flower, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Sun Sep 2 09:01:05 2018 -0400

    Issue 5410/3: flower: Fix int/size conversion warnings
    coming from g++ 8.0.1 on x86_64.
    

    commit 43cd39759fde6b2ec0f2f76e735f60355ad2ed23
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Sun Sep 2 08:54:59 2018 -0400

    Issue 5410/2: Remove unused Polynomial::set_mod
    

    commit 0c15b0f0f923c533dfba80477d8b366514dedeb9
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Sun Sep 2 08:48:42 2018 -0400

    Issue 5410/1: Remove unused memrchr and memrev
    
     
Auth0 Logo