Menu ▾ ▴

#5409 Fix many type-conversion warnings in simple-spacer.

Fixed
Dan Eble
Fixed_2_21_0 (565)
Build
2018-09-07
2018-08-30
Dan Eble
No

Fix many type-conversion warnings in simple-spacer.

Most of these changes eliminate a conversion from int to vsize
(a.k.a. size_t) by changing the public interface to use vsize.

These were observed when building with g++ 8.0.1 on x86_64.

http://codereview.appspot.com/347950043

Discussion

  • Anonymous

    Anonymous - 2018-08-31
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2018-08-31

    Passes make. make check and a full make doc.

     

  • Anonymous

    Anonymous - 2018-09-02
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2018-09-02

    Patch on countdown for September 4th

     

  • Anonymous

    Anonymous - 2018-09-05
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2018-09-05

    Patch counted down - please push

     

  • Dan Eble

    Dan Eble - 2018-09-07
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Enhancement --> Build
     

  • Dan Eble

    Dan Eble - 2018-09-07

    commit 0da060e2d5b62a5becf1f636048bfa44f1a6faa9 (HEAD -> pushed/issue-5409-warnings-simple-space
    r, origin/staging)
    Author: Dan Eble nine.fierce.ballads@gmail.com
    Date: Thu Aug 30 18:40:52 2018 -0400

    Issue 5409: Fix many type-conversion warnings in simple-spacer

Most of these changes eliminate a conversion from int to vsize
(a.k.a. size_t) by changing the public interface to use vsize.

These were observed when building with g++ 8.0.1 on x86_64.