I think the "TODO" says, we should put those snippets into the LSR not into Documentation/snippets/new/
With the next LSR import they would be available.
I'd offer to put them into LSR, though I don't know when I'll have the time to do it.
(I'll have a concert soon, practising every minute I can spare)
In Cow-and-ride-bell-example.ly and High-and-low-woodblock-example.ly the override for BarLine.bar-extent is not necessary, actually right now the BarLine is too long.
Also, the pecussion-clef looks off-center.
Probably better to use -2 and 2 for the line-positions and for the percussion-instruments either.
Cheers,
Harm
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Fix some incorrect syntax in the snippets
http://codereview.appspot.com/353760043
Fix an @ref to @ruser
http://codereview.appspot.com/353760043
Passes make make check and a full make doc
Hi James,
I think the "TODO" says, we should put those snippets into the LSR not into Documentation/snippets/new/
With the next LSR import they would be available.
I'd offer to put them into LSR, though I don't know when I'll have the time to do it.
(I'll have a concert soon, practising every minute I can spare)
In Cow-and-ride-bell-example.ly and High-and-low-woodblock-example.ly the override for BarLine.bar-extent is not necessary, actually right now the BarLine is too long.
Also, the pecussion-clef looks off-center.
Probably better to use -2 and 2 for the line-positions and for the percussion-instruments either.
Cheers,
Harm
I take that back.
rb8 8 will not work with 2.18.2...
Nevertheless, the other remarks are valid, imho
Last edit: Thomas Morley 2018-08-29
Moved snippets to LSR
http://codereview.appspot.com/353760043
Passes make, make check and a full make doc
Patch on countdown for Sept 13th
Patch counted down - please push