Menu

#5408 Doc: NR - Percussion.itely Convert examples to snippets for LSR

Fixed
Documentation
2018-09-13
2018-08-26
No

Doc: NR - Percussion.itely Convert examples to snippets for LSR

Issue

Fix the 'TODO'

Convert @lilypond examples to
Snippets.

http://codereview.appspot.com/353760043

Discussion

  • Anonymous

    Anonymous - 2018-08-27

    Fix some incorrect syntax in the snippets

    http://codereview.appspot.com/353760043

     
  • Anonymous

    Anonymous - 2018-08-29
     
  • Anonymous

    Anonymous - 2018-08-29
    • Needs: -->
    • Patch: new --> review
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2018-08-29

    Passes make make check and a full make doc

     
  • Thomas Morley

    Thomas Morley - 2018-08-29

    Hi James,

    I think the "TODO" says, we should put those snippets into the LSR not into Documentation/snippets/new/
    With the next LSR import they would be available.
    I'd offer to put them into LSR, though I don't know when I'll have the time to do it.
    (I'll have a concert soon, practising every minute I can spare)

    In Cow-and-ride-bell-example.ly and High-and-low-woodblock-example.ly the override for BarLine.bar-extent is not necessary, actually right now the BarLine is too long.
    Also, the pecussion-clef looks off-center.
    Probably better to use -2 and 2 for the line-positions and for the percussion-instruments either.

    Cheers,
    Harm

     
  • Thomas Morley

    Thomas Morley - 2018-08-29

    I'd offer to put them into LSR,

    I take that back.
    rb8 8 will not work with 2.18.2...

    Nevertheless, the other remarks are valid, imho

     

    Last edit: Thomas Morley 2018-08-29
  • Anonymous

    Anonymous - 2018-09-02
    • Patch: review --> needs_work
     
  • Anonymous

    Anonymous - 2018-09-09
     
  • Anonymous

    Anonymous - 2018-09-09
    • Needs: -->
    • Patch: new --> review
    • Type: --> Documentation
     
  • Anonymous

    Anonymous - 2018-09-09

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2018-09-10
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-09-10

    Patch on countdown for Sept 13th

     
  • Anonymous

    Anonymous - 2018-09-13
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-09-13

    Patch counted down - please push

     
  • Anonymous

    Anonymous - 2018-09-13
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2018-09-13
    author  James Lowe <pkx166h@runbox.com> 
        Sun, 26 Aug 2018 16:44:54 +0100 (16:44 +0100)
    committer   James Lowe <pkx166h@runbox.com> 
        Thu, 13 Sep 2018 16:15:46 +0100 (16:15 +0100)
    commit  ea40cc1896f76d5212689cc64f5c1e339c0834fe
    
     
MongoDB Logo MongoDB